【SCU】【Paddle TensorRT No.24】Add pd_op.minimum converter
#69736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lizexu123
reviewed
Nov 27, 2024
python/paddle/tensorrt/impls/math.py
Outdated
| def minimum_converter(network, paddle_op, inputs): | ||
| x = inputs[0] | ||
| y = inputs[1] | ||
| x, y = broadcast(network, x, y, a_name="x", b_name="y") |
There was a problem hiding this comment.
我看官方的文档就是先广播再逐元素取小咧
python/paddle/tensorrt/impls/math.py
Outdated
| y = inputs[1] | ||
| x, y = broadcast(network, x, y, a_name="x", b_name="y") | ||
| min_layer = network.add_elementwise(x, y, trt.ElementWiseOperation.MIN) | ||
| min_layer.name = f"{x.name}_minimum_{y.name}" |
lizexu123
previously approved these changes
Dec 4, 2024
|
冲突了 |
luotao1
previously approved these changes
Dec 4, 2024
lizexu123
reviewed
Dec 5, 2024
| @@ -410,6 +410,7 @@ def test_trt_result(self): | |||
|
|
|||
| class TestMinimumBroadcastTRTPattern(TensorRTBaseTest): | |||
| def setUp(self): | |||
| self.python_api = paddle.minimum | |||
There was a problem hiding this comment.
这里PR单测名错了，应该是Maximum，需要那边同学重新改一下。我这边仍然用Minimum。https://github.com/PaddlePaddle/Paddle/pull/69835/files
There was a problem hiding this comment.
我这边一起改了
这怎么又测minimum，又测maximum的
|
Sorry to inform you that 3f8a0a5's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
@lizexu123 这个应该可以了 |
lizexu123
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
新增了
pd_op.minimumMarker和Converter