[CINN]fix symbol arg binding in bc optimize #70193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Dec 13, 2024
| origin_symbol_args.at(arg_idx); | ||
| } else { | ||
| new_args_vec.emplace_back(func_args[arg_idx]); | ||
| break; |
There was a problem hiding this comment.
因为当前func_arg是按照(tensor_arg1, tensor_arg2, .. tensor_argn, ... var_arg1, var_arg2, .. var_argn)组织的，这一步只收集TensorArg，var_arg(也就是SymbolArg)后面根据原始shape_or_data生成
There was a problem hiding this comment.
那是不写成tensor_arg的判断代码更容易理解些？
| std::vector<ir::Argument> new_args_vec; | ||
| int total_args_num = 0; | ||
| int cur_arg_idx = 0; |
There was a problem hiding this comment.
Done，直接改造其构造方法并放入AddSymbolArgs函数中，语义已经明确
zyfncg
approved these changes
Dec 16, 2024
| @@ -136,7 +136,8 @@ CollectSubstituteDimExprMap( | |||
| [&](const symbol::DimExpr& dim_expr) { | |||
| if (dim_expr.isa<std::string>()) return false; | |||
| for (const auto& symbol : symbol::CollectDimExprSymbols(dim_expr)) { | |||
| if (new_symbol_set.count(symbol) == 0) { | |||
| if (new_symbol_set.count(symbol) == 0 && | |||
| base_dim_expr_set.count(symbol) == 0) { | |||
There was a problem hiding this comment.
这段逻辑是想说如果被替换之后出现了new_symbol_set或者base_dim_expr_set里都没有的符号，那么它就是一个不能被子集替换的，很多case都有，比如BC(S0, S1)，new_symbol_set里没有，输入符号里也没有S0和S1，那么它就can't BeRepresentedBySubset，需要被替换成新符号
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
Pcard-67164
This PR fixes symbol arg binding in bc optimize.