Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【GPUPS】add env for gpups and fix cache table #70301

Merged
merged 2 commits into from
Dec 23, 2024
Merged

【GPUPS】add env for gpups and fix cache table #70301

merged 2 commits into from
Dec 23, 2024

Conversation

danleifeng
Copy link
Contributor

@danleifeng danleifeng commented Dec 18, 2024 •
edited
Loading

PR Category

Parameter Server

PR Types

Bug fixes

Description

  1. set NCCL_LAUNCH_MODE=GROUP for training with no hang.
  2. fix cache table for gpups

Pcard-88634

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 18, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XiaoguangHu01
XiaoguangHu01 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SigureMo
SigureMo approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@sneaxiy sneaxiy merged commit bce4331 into PaddlePaddle:develop Dec 23, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@SigureMo SigureMo SigureMo approved these changes

@sneaxiy sneaxiy sneaxiy approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

@raindrops2sea raindrops2sea Awaiting requested review from raindrops2sea raindrops2sea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danleifeng @tianshuo78520a @sneaxiy @SigureMo @XiaoguangHu01