[CINN]Add support for TensorList input in the Pad3d infer symbolic interface #70318
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Hongqing-work
previously approved these changes
Dec 20, 2024
paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/infer_sym_utils.cc
Outdated
Show resolved
Hide resolved
zyfncg
reviewed
Dec 20, 2024
Comment on lines
79
to
83
| if (x_shape_or_data.data().has_value() && x_shape_or_data.shape().empty() && | ||
| x_shape_or_data.data().value().size() == 1) { // 0D tensor | ||
| infer_context->SetShapeOrDataForValue(op->result(0), x_shape_or_data); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
0D tensor 和 data有关系吗？
这里的逻辑感觉也有点问题
There was a problem hiding this comment.
奥这里是reduceInferDim那个pr需要修改的内容，测完模型没有删
There was a problem hiding this comment.
这里的逻辑感觉也有点问题
这里的原逻辑是想有data就对data进行reduceinfer，感觉是为了简化写法？可以优化下
There was a problem hiding this comment.
reduce算子应该不会把输入x的data往shape上弄，有data肯定也只能是往输出的data上放
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
Pcard-67164