[Cherr-pick] Fix take_along_axis_grad and p_norm_decomp
#70340
Merged
+51
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
…addlePaddle#70250) * fix take_along_axis_grad when duplicated entries in indices * update unitest * add grad check * use include_self=True to avoid BUG
zyfncg
previously approved these changes
Dec 20, 2024
phlrain
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
Pcard-75624
p_norm_decomp的asvector=True时，规约axis和结果形状不正确的问题take_along_axis_grad中，当indices内含有重复的下标时，结果错误的问题，从assign模式改为add模式解决（include_self暂时需要指定为True，不能为False，否则计算结果错误）。Related PR: #70250 , #69675