Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][Typos][K-1] Fix typo (kenerl, kerenl, kernal) #70354

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[CodeStyle][Typos][K-1] Fix typo (kenerl, kerenl, kernal) #70354

merged 3 commits into from
Dec 20, 2024

Conversation

huangkr03
Copy link
Contributor

@huangkr03 huangkr03 commented Dec 19, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Devs

Description

Fix:

  • kenerl
  • kerenl
  • Kernal
  • Kernerl

Undo:

@huangkr03
kenerl -> kernel
91fb825 
kerenl -> kernel
@huangkr03 huangkr03 requested a review from SigureMo as a code owner December 19, 2024 14:40
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 19, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 19, 2024
@SigureMo
Copy link
Member

部分Kernal 涉及 API 名称变动

非 API

kernerl 涉及文件名变动

文件名也需要改

@huangkr03 huangkr03 changed the title [CodeStyle][Typos][K-1] Fix typo (kenerl, kerenl, kernal) [CodeStyle][Typos][K-1] Fix typo (kenerl, kerenl, kernal, kernerl) Dec 19, 2024
@SigureMo SigureMo changed the title [CodeStyle][Typos][K-1] Fix typo (kenerl, kerenl, kernal, kernerl) [CodeStyle][Typos][K-1] Fix typo (kenerl, kerenl, kernal) Dec 19, 2024
SigureMo
SigureMo approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@huangkr03
Copy link
Contributor Author

LGTMeow 🐾

你好，检查失败请问是为什么嘞？

@SigureMo
Copy link
Member

approval check，即需要 approve，不用管

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 20, 2024
@luotao1 luotao1 merged commit 72140ae into PaddlePaddle:develop Dec 20, 2024
28 checks passed
@SigureMo SigureMo mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huangkr03 @CLAassistant @SigureMo @luotao1