[CINN] Accelerate recompute ips #70386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
approved these changes
Dec 23, 2024
| "pd_op.log", | ||
| "pd_op.log1p", | ||
| "pd_op.logit", | ||
| "pd_op.max", | ||
| # "pd_op.max", | ||
| # "pd_op.min", |
There was a problem hiding this comment.
slice, gather, transpose这些算子是否做recompute有哪些判定条件？直观上看这些算子recompute有可能会引起显存增加或者性能下降的情况
There was a problem hiding this comment.
没有特殊判定条件。后续在分析一下，确认有问题的话（连同下面说的any）一起ban掉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
pcard-67164
some benchmark models show worse performance on ips after turning on Auto-ecompute Flag. One of the reasons we've found is that SUM op which is recomputable actually will be changed into compute intensive REDUCE_SUM op and takes long time to run. Therefore we remove sum op from default recomputable ops.