Skip to content

Commit

Permalink
ci: remove cargo-udeps job
Browse files Browse the repository at this point in the history
Recently we've been seeing the cargo-udeps job take upwards of 30+
minutes to run. This has overwhelmingly become the long-poll in CI by
being 3x longer than the next slowest job. The signal we get from this
job vs the time we spend running it has become a non-ideal trade-off and
as such this patch removes the job.
  • Loading branch information
bmwill committed May 25, 2022
1 parent 3c75d6f commit e5bf59c
Showing 1 changed file with 0 additions and 34 deletions.
34 changes: 0 additions & 34 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,37 +117,3 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: EmbarkStudios/cargo-deny-action@v1

cargo-udeps:
needs: diff
if: needs.diff.outputs.isRust == 'true'
runs-on: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
# Enable caching of the 'librocksdb-sys' crate by additionally caching the
# 'librocksdb-sys' src directory which is managed by cargo
- uses: bmwill/rust-cache@v1 # Fork of 'Swatinem/rust-cache' which allows caching additional paths
with:
path: ~/.cargo/registry/src/**/librocksdb-sys-*
- name: Install cargo-udeps, and cache the binary
uses: baptiste0928/cargo-install@v1
with:
crate: cargo-udeps
locked: true
- name: Install cargo-hakari, and cache the binary
uses: baptiste0928/cargo-install@v1
with:
crate: cargo-hakari
locked: true
# Normally running cargo-udeps requires use of a nightly compiler
# In order to have a more stable and less noisy experience, lets instead
# opt to use the stable toolchain specified via the 'rust-toolchain' file
# and instead enable nightly features via 'RUSTC_BOOTSTRAP'
- name: run cargo-udeps
run: |
# First we need to disable the workspace-hack package
cargo hakari disable
cargo hakari remove-deps -y
RUSTC_BOOTSTRAP=1 cargo udeps

0 comments on commit e5bf59c

Please sign in to comment.