Skip to content

Commit

Permalink
[FLINK-6732] [java] Activate strict checkstyle for flink-java
Browse files Browse the repository at this point in the history
  • Loading branch information
zentol committed Jul 31, 2017
1 parent 8e97536 commit 3c42557
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 80 deletions.
2 changes: 1 addition & 1 deletion docs/internals/ide_setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ You can scan an entire module by opening the Checkstyle tools window and
clicking the "Check Module" button. The scan should report no errors.

<span class="label label-info">Note</span> Some modules are not fully covered by checkstyle,
which include `flink-core`, `flink-java`, `flink-optimizer`, and `flink-runtime`.
which include `flink-core`, `flink-optimizer`, and `flink-runtime`.
Nevertheless please make sure that code you add/modify in these modules still conforms to the checkstyle rules.

## Eclipse
Expand Down
29 changes: 0 additions & 29 deletions flink-java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -85,35 +85,6 @@ under the License.

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>6.19</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>validate</id>
<phase>validate</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>

<configuration>
<configLocation>/tools/maven/checkstyle.xml</configLocation>
<suppressionsLocation>/tools/maven/suppressions-java.xml</suppressionsLocation>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<logViolationsToConsole>true</logViolationsToConsole>
<failOnViolation>true</failOnViolation>
</configuration>
</plugin>

<!-- activate API compatibility checks -->
<plugin>
Expand Down
50 changes: 0 additions & 50 deletions tools/maven/suppressions-java.xml

This file was deleted.

0 comments on commit 3c42557

Please sign in to comment.