-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patcher v2 #265
patcher v2 #265
Conversation
e21d07f
to
8931470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't thoroughly reviewed the code, but generally looks really nice.
I did thoroughly test this in paper, fork test and fork fork test tho and it behaves as expected (minus the things I noted internally)
1dc821a
to
da6b698
Compare
Still a work in progress
…e patch & other commit messages identifying
Given the nature of these tasks caching ends up being mostly a waste of time and disk space
Similar to the bundler/paperclip tasks, caching is not useful here outside of edge cases that the downsides outweigh
Heya - SetupPaperScript - L137 has a small issue |
This is unrelated to this PR, you should open a separate issue or PR |
…spath We may need to revisit this in the future, but it seems to work with basic testing and provides a decent speedup by not needing to compile -API
No description provided.