Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patcher v2 #265

Merged
merged 44 commits into from
Dec 21, 2024
Merged

patcher v2 #265

merged 44 commits into from
Dec 21, 2024

Conversation

jpenilla
Copy link
Member

No description provided.

@jpenilla jpenilla force-pushed the patcher-v2 branch 3 times, most recently from e21d07f to 8931470 Compare December 16, 2024 04:12
Copy link
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't thoroughly reviewed the code, but generally looks really nice.
I did thoroughly test this in paper, fork test and fork fork test tho and it behaves as expected (minus the things I noted internally)

@jpenilla jpenilla force-pushed the patcher-v2 branch 11 times, most recently from 1dc821a to da6b698 Compare December 20, 2024 20:21
@ComputerNerd100
Copy link

Heya - SetupPaperScript - L137 has a small issue
Current code: val paperFolder = Path("~").resolve(".paper") puts the script into the gradle daemon directory
val paperFolder = Path(System.getenv("HOME")).resolve(".paper") would work instead though :))

@jpenilla
Copy link
Member Author

Heya - SetupPaperScript - L137 has a small issue Current code: val paperFolder = Path("~").resolve(".paper") puts the script into the gradle daemon directory val paperFolder = Path(System.getenv("HOME")).resolve(".paper") would work instead though :))

This is unrelated to this PR, you should open a separate issue or PR

@jpenilla jpenilla marked this pull request as ready for review December 21, 2024 21:19
@jpenilla jpenilla merged commit f0563fd into main Dec 21, 2024
3 checks passed
@jpenilla jpenilla deleted the patcher-v2 branch December 21, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants