fix: return error if content and password are both read from stdin (o…

…ras-project#892)

Signed-off-by: Billy Zha <[email protected]>

cmd/oras/manifest/push.go

@@ -82,13 +82,13 @@ Example - Push a manifest to an OCI layout folder 'layout-dir' and tag with 'v1'
 `,
 		Args: cobra.ExactArgs(2),
 		PreRunE: func(cmd *cobra.Command, args []string) error {
+			opts.fileRef = args[1]
 			if opts.fileRef == "-" && opts.PasswordFromStdin {
 				return errors.New("`-` read file from input and `--password-stdin` read password from input cannot be both used")
 			}
 			refs := strings.Split(args[0], ",")
 			opts.RawReference = refs[0]
 			opts.extraRefs = refs[1:]
-			opts.fileRef = args[1]
 			return option.Parse(&opts)
 		},
 		RunE: func(_ *cobra.Command, args []string) error {

test/e2e/suite/command/manifest.go

@@ -67,6 +67,13 @@ var _ = Describe("ORAS beginners:", func() {
 					MatchErrKeyWords("Error:").
 					Exec()
 			})
+
+			It("should fail pushing with  a manifest from stdin without media type flag", func() {
+				tag := "from-stdin"
+				ORAS("manifest", "push", RegistryRef(Host, ImageRepo, tag), "-", "--password-stdin", "--media-type", "application/vnd.oci.image.manifest.v1+json").
+					ExpectFailure().
+					MatchErrKeyWords("`-`", "`--password-stdin`", " cannot be both used").Exec()
+			})
 		})
 
 		When("running `manifest fetch`", func() {