Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync lamp info #95

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Sync lamp info #95

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
10f1194
Hotfix dev mode
BinaryBrain Aug 18, 2024
b3971f1
Sync lamp info
BinaryBrain Aug 18, 2024
ed4bb04
Fix root location
BinaryBrain Aug 18, 2024
6d7727f
Sync color picker and other characteristics
BinaryBrain Aug 18, 2024
6ff0429
Add condition to avoid a crash
BinaryBrain Aug 18, 2024
5dea030
Add brightness to sync
BinaryBrain Aug 18, 2024
3324d24
TS version === 4.3.5
BinaryBrain Aug 18, 2024
71c1c28
remove console log
BinaryBrain Aug 18, 2024
8b38672
Fix concurrency issue when posting characteristics and animation name
BinaryBrain Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add condition to avoid a crash
  • Loading branch information
@BinaryBrain
BinaryBrain committed Aug 18, 2024
commit 6ff04296c06c2b12fe61735c365e3381a7d9e826
6 changes: 4 additions & 2 deletions server/lamp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,10 @@ export function initLamp() {
// We set the default value to the current one to sync clients
if (currentCharacteristics[animationName]) {
for (let i = 0; i < options.length; i++) {
options[i].currentCharacteristicValue =
currentCharacteristics[animationName][i].value;
if (typeof currentCharacteristics[animationName][i]?.value !== "undefined") {
options[i].currentCharacteristicValue =
currentCharacteristics[animationName][i].value;
}
}
} else {
options.forEach((option) => {
Expand Down
Loading