Skip to content

Commit

Permalink
make deleted function public (facebook#30)
Browse files Browse the repository at this point in the history
Summary:
This apparently gives better compiler error messages.

Pull Request resolved: facebookincubator/fbjni#30

Test Plan: CI

Reviewed By: mhorowitz

Differential Revision: D19396160

Pulled By: dreiss

fbshipit-source-id: 8e86d8c684be81bc74b03bfc58d71f5c21dac095
  • Loading branch information
gengjiawen authored and facebook-github-bot committed Jan 14, 2020
1 parent d09319f commit 3d60803
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion first-party/fbjni/cxx/fbjni/detail/References.h
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,14 @@ struct ReprStorage {
JniType<Repr> jobj() const noexcept;

void swap(ReprStorage& other) noexcept;
private:

ReprStorage() = delete;
ReprStorage(const ReprStorage&) = delete;
ReprStorage(ReprStorage&&) = delete;
ReprStorage& operator=(const ReprStorage&) = delete;
ReprStorage& operator=(ReprStorage&&) = delete;

private:
using Storage = typename std::aligned_storage<sizeof(JObjectBase), alignof(JObjectBase)>::type;
Storage storage_;
};
Expand Down

0 comments on commit 3d60803

Please sign in to comment.