Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file lock to avoid concurrent edits #1403

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Add file lock to avoid concurrent edits #1403

merged 2 commits into from
Feb 12, 2025

Conversation

tientong98
Copy link
Contributor

Closes #1242

Changes proposed in this pull request

Add file lock for: xcpd dataset_description.json, atlas dataset_description.json, and all files created by the CopyAtlas class

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (52552ad) to head (0dd2efb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
+ Coverage   78.49%   78.52%   +0.02%     
==========================================
  Files          58       58              
  Lines        7305     7315      +10     
  Branches      962      962              
==========================================
+ Hits         5734     5744      +10     
  Misses       1292     1292              
  Partials      279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tientong98 tientong98 requested a review from tsalo February 11, 2025 23:04
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this!

@tientong98 tientong98 merged commit 3377134 into main Feb 12, 2025
24 checks passed
@tientong98 tientong98 deleted the enh/file-lock branch February 12, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use file lock to avoid concurrent edits to dataset_description.json
2 participants