Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Capture] merge_amplitude_embedding is plxpr compatible #6925

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Feb 4, 2025

Context:

This PR adds a MergeAmplitudeEmbeddingInterpreter to apply the merge_amplitude_embedding transform natively to plxpr.

Description of the Change:

  • Add MergeAmplitudeEmbeddingInterpreter to transform plxpr

Benefits:

merge_amplitude_embedding can be applied natively to plxpr.

Possible Drawbacks: None identified.

[sc-83685]

@andrijapau andrijapau marked this pull request as draft February 4, 2025 20:53
@andrijapau andrijapau marked this pull request as ready for review February 4, 2025 21:36
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (9744822) to head (017fd5e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6925   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files         480      480           
  Lines       45495    45589   +94     
=======================================
+ Hits        45310    45404   +94     
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant