de-dupe env keys

PhilSwanteck1 · Mar 14, 2023 · d248850 · d248850
1 parent 8488a58
commit d248850
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/hooks/useShellEnv.ts b/src/hooks/useShellEnv.ts
@@ -155,8 +155,12 @@ function suffixes(key: EnvKey) {
 
 export function expand(env: Record<string, string[]>) {
   let rv = ''
-  for (const [key, value] of Object.entries(env)) {
+  for (let [key, value] of Object.entries(env)) {
     if (value.length == 0) continue
+    // so far we don’t know any situation where we want dupes
+    // but we've seen a few where this breaks things, notably for single value keys that have
+    // gotten duped
+    value = value.uniq()
     rv += `export ${key}="${value.join(":")}"\n`
   }
   return rv