[TypeChecker] Effects: Don't diagnose implicit AST nodes

Implicitly generated code requires checking but it doesn't have to produce a diagnostic into the void.
Pogosito · May 31, 2022 · d461eab · d461eab
1 parent 0989cd9
commit d461eab
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/lib/Sema/TypeCheckEffects.cpp b/lib/Sema/TypeCheckEffects.cpp
@@ -1787,6 +1787,9 @@ class Context {
   void diagnoseUnhandledThrowSite(DiagnosticEngine &Diags, ASTNode E,
                                   bool isTryCovered,
                                   const PotentialEffectReason &reason) {
+    if (E.isImplicit())
+      return;
+
     switch (getKind()) {
     case Kind::PotentiallyHandled:
       if (IsNonExhaustiveCatch) {
@@ -1966,6 +1969,9 @@ class Context {
   void diagnoseUnhandledAsyncSite(DiagnosticEngine &Diags, ASTNode node,
                                   Optional<PotentialEffectReason> maybeReason,
                                   bool forAwait = false) {
+    if (node.isImplicit())
+      return;
+
     switch (getKind()) {
     case Kind::PotentiallyHandled: {
       Diags.diagnose(node.getStartLoc(), diag::async_in_nonasync_function,

diff --git a/test/decl/var/async_let.swift b/test/decl/var/async_let.swift
@@ -9,7 +9,6 @@ func test() async {
 
 struct X {
   async let x = 1 // expected-error{{'async let' can only be used on local declarations}}
-  // FIXME: expected-error@-1{{'async' call cannot occur in a property initializer}}
 }
 
 func testAsyncFunc() async {

diff --git a/test/expr/unary/async_await.swift b/test/expr/unary/async_await.swift
@@ -196,10 +196,9 @@ func testAsyncLet() async throws {
   _ = await x5
 }
 
-// expected-note@+1 4{{add 'async' to function 'testAsyncLetOutOfAsync()' to make it asynchronous}} {{30-30= async}}
+// expected-note@+1 3{{add 'async' to function 'testAsyncLetOutOfAsync()' to make it asynchronous}} {{30-30= async}}
 func testAsyncLetOutOfAsync() {
   async let x = 1 // expected-error{{'async let' in a function that does not support concurrency}}
-  // FIXME: expected-error@-1{{'async' call in a function that does not support concurrency}}
 
   _ = await x  // expected-error{{'async let' in a function that does not support concurrency}}
   _ = x // expected-error{{'async let' in a function that does not support concurrency}}

diff --git a/test/stmt/async.swift b/test/stmt/async.swift
@@ -7,9 +7,8 @@ func omnom(_ x: Int)
 
 func f() async -> Int { 0 }
 
-func syncContext() {        // expected-note 4 {{add 'async' to function 'syncContext()' to make it asynchronous}}
+func syncContext() {        // expected-note 3 {{add 'async' to function 'syncContext()' to make it asynchronous}}
     _ = await f()           // expected-error{{'async' call in a function that does not support concurrency}}
     async let y = await f() // expected-error{{'async let' in a function that does not support concurrency}}
-                            // expected-error@-1{{'async' call in a function that does not support concurrency}}
     await omnom(y)          // expected-error{{'async let' in a function that does not support concurrency}}
 }