-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clone - adding option to choose an endpoint prefix. #3
clone - adding option to choose an endpoint prefix. #3
Conversation
What versions of the libraries are you using? I am getting an error on
|
Update: I got it to run with |
47b6673
to
4b1ae58
Compare
Updated description with the test I ran. |
Looks good, will merge after that one nit is fixed |
@@ -13,6 +13,7 @@ def __init__(self): | |||
transform = subparsers.add_parser('clone') | |||
transform.add_argument('--source', type=str, default='http://localhost/') | |||
transform.add_argument('--destination', type=str, default='./data') | |||
transform.add_argument('--replacement-url', type=str, default='https://pokeapi.co/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does need an update to the regex to allow https
Untested.
Tested with
build_languages()
anddata/language/
directory.E.g.: