Promote v1.0.0 to master #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit this repository was bare. This commit adds the initial interface for OSCC and ROS called roscco.
Prior to this commit the readme was lacking in information to a new user. This commit fixes that by providing information about what ROSCCO is, how to build it examples of using it and how to run the tests.
Prior to this commit the CMakefile and package.xml files had commented out example code provided from the catkin_create which is not needed to run this package. This commit fixes that by removing the commented out lines.
Prior to this commit this repo used a static library and the header files for rapid check rather than a git submodule to work with ROS build system. This commit removes the duplicate headers and static library in favor of the submodule option while still working with the ros test process.
Prior to this commit there was a try catch finally block where the catch rethrew the same error so that the finally would still clean resources despite failure. This commit does away with the extra catch since it's possible to use a try finally in groovy.
Prior to this commit other projects depending on roscco would fail due to the roscco target library not being an artifact despite being listed as an output target. This commit fixes that by listing the actual output libraries.
Prior to this commit the rosco_node file had inconsistencies with formatting. This commit fixes that by updating the formatting to follow the rest of the code.
Prior to this commit ROS initialization would intermittently throw ROS errors not connecting to master but recover due to SIGIO interrupts from OSCC. This commit fixes that by blocking interupts during the ROS initialization process.
Prior to this commit this repository did not follow the ROS style guide. This commit changes that by using the clang-format file provied in the ROS style guide instrucitons. http://wiki.ros.org/CppStyleGuide
Prior to this commit there were catkin linter errors. This commit fixes that by addressing the errors produced.
Prior to this commit ROSCCO used an older version of OSCC this commit updates the dependency.
Prior to this commit ROSCCO did not disable before closing the OSCC connection relying on the 200 ms timoeout. This commit calls the disable before close to avoid relying on the timeout upon close.
Prior to this commit the topics advertised were using CamelCase rather than snake_case which is the ROS standard. This commit fixes that by changing the advertised topics to snake_case.
Prior to this commit this repo did not have an example about how to use ROSCCO. This commit fixes that by adding an example node that translates the ROS joystick node messages into ROSCCO messages with documantation about how the example works.
Prior to this commit there was a missing delete in one of the message callbacks. This commit fixes that by adding the required delete function to prevent memory leaks.
Prior to this commit the controller models were not called out and the steering did not have any smoothing algorithm making it difficult to control. This commit fixes that by calling out the game controllers used and adds an exponential average to the steering control.
Prior to this commit it was required to include defines in CMakeLists.txt for each available OSCC vehicle. OSCC now has a config file so that it does not need to be tracked in each project depending on OSCC. This commit utilizes that change.
Prior to this commit the joystick commander node example had non descript constants and variables. This commit fixes that by placing the values in named variables and adding comments to clarify what they are for and why.
Prior to this commit the trigger threshold was a mutable value which could yield undesirable results if the value was changed. This commit fixes that by setting the variable to be a constant.
Prior to this commit ROSCCO depended on a development branch version of OSCC rather than a released version of OSCC. This commit updates ROSCCO to depend on the released version 1.1.0. It also updates the Fault Report message to support the added dtcs value provided by the version upgrade.
Prior to this commit the documentation was lacking in clarity of what dependencies were required prior to using the components in ROSCCO. Also the README was lacking in clear header organizatoin. This commit fixes that by reorganizing the README headers, providing more details about the dependencies for this project and providing clarity of the Licensing information as well as corrections to the grammer in the description of the package.
Prior to this commit failed tests passed because catkin_make run_tests returns 0 regardless of success or failure of the tests. This commit fixes that by adding a second executable call which returns the correct exit code for status based on test results.
Prior to this commit there were lingering constants and inconsitant naming of the example node. This commit fixes that by using consistant naming of the node and moves the constants to the top of the code.
Prior to this commit the change to the fault report from updating OSCC was not included which caused compiler errors. This commit fixes that by updating the fault report struct to follow the rest of the updates made in ROSCCO.
Prior to this commit tests were failing because they were not updated along with the rest of ROSCCO when the naming convention to use snake case on publish and subscription topics was updated. This commit fixes that by using the correct snake case naming convention in the tests that is used in the rest of ROSCCO.
Prior to this commit the README documentation used old variable naming for the example node. This commit fixes that by using the correct variable naming for the ROSCCO example.
Prior to this commit the example changes made it into a previous commit but were incomplete and contained dead code. This commit fixes that by removing dead code and using the correct variable names.
Prior to this commit the mapping functions that were added for clarity were mapped inversly to what their behavior are. This commit fixes that by mapping the triggers and steering to the desired behavior.
Prior to this commit the example deviated from the ROS coding standards. This commit fixes that by using the clang format to make it follow the ROS standard.
Prior to this commit the CanFrame message contained reserved values which may or may not exist on other targets. This commit fixes that by removing them and assigning the values on an individual variable basis.
Prior to this commit some variables were in an initializer list while other were initialized in the class definition also there weren't const infront of function arguments. This commit clarifies the example by placing const infront of the function arguments and places all initilization values with the variable decelaration.
Prior to this commit there was some confusing vocabulary. This commit fixes that by restructuring some of the sentences.
Prior to this commit the FaultOriginId was a signed int for the enum which is conflicting with the OSCC enum type. This commit fixes that by using unsigned int.
Prior to this commit it was assumed the data message array size was known. This commit fixes that by adding a constant to the CanFrameData msg file so that it is clear what size the data array is.
Prior to this commit the repo was missing documentation for the public functions and the constants did not have consistant naming. This commit fixes that by using noisy snake case on constant variables across files and adds doxygen comments to all public functions.
Prior to this commit this repo had spelling errors and lower case acronyms. This commit fixes that by correcting the spelling errors and making the acronyms uppercase.
Merge branch 'feat/add-oscc-interface-node' into devel
# Conflicts: # LICENSE # README.md # # It looks like you may be committing a merge. # If this is not correct, please remove the file # .git/MERGE_HEAD # and try again. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # On branch devel # Your branch is up-to-date with 'origin/devel'. # # All conflicts fixed but you are still merging. #
Prior to this commit this repository did not have a release version. Now that devel branch has been tested and code has been accepted this commit promotes the package version so that it will match the release tag when devel is promoted to master and released.
jlamb-at-polysync
approved these changes
Nov 6, 2017
vertexmachina
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cuts a release of ROSCCO to v1.0.0 to master and provides: