Commits

Branch selector

 master

User selector

galganif

Datepicker

All time

Commit History

Commits on May 24, 2021

• Mark some tests as flaky, based on https://fusion2.corp.google.com/invocations/e2457134-44cf-416b-b256-a242bc627210/targets.

  Show description for 70305ec
  

  galganif

  authored and

  arcs-c3po

  committed
  70305ec

Commits on May 11, 2021

• expose database names

  Show description for d43c6b6
  

  galganif

  authored and

  arcs-c3po

  committed
  d43c6b6

Commits on May 6, 2021

• set status to LAUNCHED for all flags that have launched to dogfood, this way they are included in all perf tests. then we can clean them up entirely.

  Show description for 4c5cf52
  

  galganif

  authored and

  arcs-c3po

  committed
  4c5cf52

Commits on Apr 25, 2021

• writeonly stack integration test, verifies a write only stack is instantiated, and an entity succesful roundtrip (or sequence of operations).

  Show description for ed5e0f0
  

  galganif

  authored and

  arcs-c3po

  committed
  ed5e0f0

Commits on Apr 22, 2021

• Enable writeonlystack build flag

  Show description for 2835e61
  

  galganif

  authored and

  arcs-c3po

  committed
  2835e61

Commits on Apr 20, 2021

• onDowngrade fix: avoid dropping system tables such as sqlite_sequence which may not be dropped.

  Show description for ae51790
  

  galganif

  authored and

  arcs-c3po

  committed
  ae51790

Commits on Apr 14, 2021

• Enable remove_by_query_handle flag.

  Show description for fb2f6aa
  

  galganif

  authored and

  arcs-c3po

  committed
  fb2f6aa

Commits on Apr 6, 2021

• Fix bug in delete propagation query, which was over-joining with the entity_refs field for non-ref fields such as inline entities.

  Show description for 8da505d
  

  galganif

  authored and

  arcs-c3po

  committed
  8da505d

Commits on Mar 30, 2021

• Change AndroidSqliteDatabaseManager to not remove instance from the cache when all clients disconnect. The fact that all clients are disconnected does not mean that there are no writes going on (eg…

  Show description for 1f1c721
  

  galganif

  authored and

  arcs-c3po

  committed
  1f1c721

Commits on Mar 18, 2021

• add fuzz test for write-only stack using the invariant_storeRoundTrip_sameAsCrdtModel invariant. for this, we use a generators of FixtureEntities. includes some tweaks to some existing generators. …

  Show description for 4237862
  

  galganif

  authored and

  arcs-c3po

  committed
  4237862

Commits on Mar 17, 2021

• Change applyop notify logic to no-op if the collection does not exist, instead of throwing an error. This can happen for example if the first op ever is a remove or clear.

  Show description for 0161bcf
  

  galganif

  authored and

  arcs-c3po

  committed
  0161bcf

Commits on Mar 16, 2021

• Add a storage-side integration test for write-only-stack. The test involves the WriteOnlyDirectStore, DatabaseDriver and DatabaseImpl, to verify data looks as expected in the database, and that it …

  Show description for e9f890c
  

  galganif

  authored and

  arcs-c3po

  committed
  e9f890c

Commits on Mar 10, 2021

• go/arcs-write-only-stack: WriteOnlyDirectStore with tests. WriteOnlyDirectStore only forwards operations to the driver, and throws exception on modelupdate or syncrequest from the proxy.

  Show description for fa295d9
  

  galganif

  authored and

  arcs-c3po

  committed
  fa295d9

Commits on Mar 9, 2021

• go/arcs-write-only-stack: add new applyOps method to the Driver interface. Only the databasedriver supports it: it splits the ops into reference+entity, and sends them to the database.

  Show description for 1714b0c
  

  galganif

  authored and

  arcs-c3po

  committed
  1714b0c

• go/arcs-write-only-stack: add support to use the DatabaseDriver with a ReferenceModeStorageKey. As explained in the doc, the new stack will use a single instance of a db driver to write all data to…

  Show description for 240846a
  

  galganif

  authored and

  arcs-c3po

  committed
  240846a

• In ReferenceModeStore, when an update is received from the container store, we clear items from the in-memory entity version maps, removing those items that are no longer in the collection.

  Show description for dbd5170
  

  galganif

  authored and

  arcs-c3po

  committed
  dbd5170

• Add a fuzz test for databaseimpl applyOp function

  Show description for 7ce207c
  

  galganif

  authored and

  arcs-c3po

  committed
  7ce207c

• Write-only-stack: add DatabaseOp for remove and clear, behind the flag. When removing one or more items from the collection, we also clear (tombstone) the entity.

  Show description for 480125e
  

  galganif

  authored and

  arcs-c3po

  committed
  480125e

Commits on Mar 7, 2021

• Add a new applyOp method to the database, and the AddToCollection DatabaseOp. The new method is behind a new build flag.

  Show description for 555591b
  

  galganif

  authored and

  arcs-c3po

  committed
  555591b

Commits on Mar 3, 2021

• add writeOnly boolean to StoreOptions, to signal to storage service that it can instantiate a write-only optimized stack

  Show description for e410c0f
  

  galganif

  authored and

  arcs-c3po

  committed
  e410c0f

Commits on Feb 2, 2021

• Extract separate interface and impl for StorageServiceManagerEndpoint, so that it can be mocked/faked in tests.

  Show description for c0d231e
  

  galganif

  authored and

  arcs-c3po

  committed
  c0d231e

Commits on Jan 27, 2021

• deflake StorageServiceManagerTest: it was possible that we were checking the handle values before the update arrived. Make sure we wait for onupdate before we check that the data is gone.

  Show description for cf6445d
  

  galganif

  authored and

  arcs-c3po

  committed
  cf6445d

Commits on Jan 24, 2021

• Deflake HandleManagerImplTest: flakiness was due to reusing the same storage key for a collection and a singleton, resulting in incompatible model updates. Added a check in the impl to invalidate r…

  Show description for c048d12
  

  galganif

  authored and

  arcs-c3po

  committed
  c048d12

Commits on Jan 14, 2021

• Simplify DirectStoreMuxerTest: split one test in two, use common vals and functions.

  Show description for 8263740
  

  galganif

  authored and

  arcs-c3po

  committed
  8263740

• Run GarbageCollection via aidl, change 3/3: StorageService config to be able to switch worker. This can be controlled by AiAiStorageService which wires it up to a new mendel flag. Both values of th…

  Show description for 5541c30
  

  galganif

  authored and

  arcs-c3po

  committed
  5541c30

Commits on Jan 13, 2021

• Run GarbageCollection via aidl, change 2/3: add a new worker which calls the aidl method. The worker is not yet scheduled. The worker is in the sdk package to avoid a circular dependency with Stora…

  Show description for 74a3779
  

  galganif

  authored and

  arcs-c3po

  committed
  74a3779

Commits on Jan 12, 2021

• Run GarbageCollection via aidl, change 1/3: add new aidl method to StorageServiceManager, and corresponding helper to StorageServiceManagerEndpoint. The method is not yet called anywhere.

  Show description for 254548a
  

  galganif

  authored and

  arcs-c3po

  committed
  254548a

Commits on Dec 31, 2020

• create StorageServiceManagerEndpoint to bind to storage service manager and perform deletes for foreign hard references.

  Show description for ab7f43c
  

  galganif

  authored and

  arcs-c3po

  committed
  ab7f43c

Commits on Dec 30, 2020

• Add methods to storageservicemanager aidl to perform hard references deletes, calling the hardreferencemanager

  Show description for ae7ba2b
  

  galganif

  authored and

  arcs-c3po

  committed
  ae7ba2b

Commits on Dec 29, 2020

• move tests in TtlHandleTest to the integration environment TtlTest, so they are more end to end.

  Show description for 8322208
  

  galganif

  authored and

  arcs-c3po

  committed
  8322208

• in preparation to move this functionality behind an aidl, rename ForeignReferenceManager->HardReferenceManager and make it take a storage key, since the schema is hard to pass across the aidl, wher…

  Show description for 91fffdd
  

  galganif

  authored and

  arcs-c3po

  committed
  91fffdd

• After removing hard references, remove the now unused refs as well, instead of waiting for the next GC run, as the refs can contain IDs with sensitive information.

  Show description for c7b631f
  

  galganif

  authored and

  arcs-c3po

  committed
  c7b631f

• Make removeEntitiesHardReferencing return the number of top-level removed entities, so we can use that value for analytics, as discussed in #6423 (comment).

  Show description for a991112
  

  galganif

  authored and

  arcs-c3po

  committed
  a991112

Commits on Dec 28, 2020

• remove custom assertSuspendingThrows method, instead use assertFailsWith

  Show description for a576cf6
  

  galganif

  authored and

  arcs-c3po

  committed
  a576cf6

• move method to wait for entities to reach the driver, to a common location so it can be shared.

  Show description for 1a82c28
  

  galganif

  authored and

  arcs-c3po

  committed
  1a82c28

Pagination

Previous

Next