Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated verify_policy tool #7142

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Updated verify_policy tool #7142

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec36bd6
Updated VerifyPolicy
alxmrs Apr 30, 2021
f078068
Less verbose log statement.
alxmrs Apr 30, 2021
2c08bad
Nit
alxmrs Apr 30, 2021
d7852ac
Reverted changes to InformationFlow.kt.
alxmrs Apr 30, 2021
802861e
Updated OSS tooling to support new CLI.
alxmrs May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Nit
  • Loading branch information
@alxmrs
alxmrs committed Apr 30, 2021
commit 2c08bad211060ba318dc3ff256a96e409f30c88e
2 changes: 1 addition & 1 deletion java/arcs/core/analysis/InformationFlow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ private fun Predicate.labels(): List<InformationFlowLabel> = when (this) {
fun InformationFlow.AnalysisResult.verify(particle: Recipe.Particle, check: Check): Boolean {
val log = TaggedLog { "AnalysisResult.verify" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much debug information. Let us not keep these log.debug statements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, just pushed a reversion.


log.debug { "checking $check in ${particle.spec.name}"}
log.debug { "checking $check in ${particle.spec.name}" }

val result = fixpoint.getValue(particle)

Expand Down