Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic creation/updating of metadata in .raph for MetaGraph #1976

Merged
merged 9 commits into from
Apr 1, 2025

Conversation

louisch
Copy link
Contributor

@louisch louisch commented Mar 21, 2025

What changes were proposed in this pull request?

Add functions hooking into graph creation and graph writes to create/update metadata within the .raph file, which can then be fetched from the MetaGraph resource from GraphQL.

This metadata currently consists of:

  • node count
  • edge count
  • graph properties

Why are the changes needed?

To provide an endpoint to fetch this information without having to decode and fetch the full graph.

Does this PR introduce any user-facing change? If yes is this documented?

A new endpoint is provided from GQL, and the new behavior will modify the .raph file, but should not be a breaking change for users.

How was this patch tested?

Tests added to raphtory-graphql to test that the metadata is created/updated and can be fetched via MetaGraph (as well as namespaces in general), and also tests were added to check that the right behavior happens if an invalid .raph file exists.

Are there any further changes required?

None unless more complex metadata is required in the future, or a more complex storage method is needed.

Copy link
Collaborator

@fabianmurariu fabianmurariu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good overall, just one comment on StaticGraphViewOps

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2025

CLA assistant check
All committers have signed the CLA.

Base automatically changed from graphql-ls to master March 31, 2025 15:01
@ljeub-pometry ljeub-pometry force-pushed the feature/metadata-basic-creation branch from e201a9d to 5fd1915 Compare March 31, 2025 15:26
Copy link
Collaborator

@fabianmurariu fabianmurariu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianmurariu fabianmurariu merged commit 48ec588 into master Apr 1, 2025
20 checks passed
@fabianmurariu fabianmurariu deleted the feature/metadata-basic-creation branch April 1, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants