client/comms.c: fix buffer overflow

Don't copy more bytes into pm3_capabilities as its size. Fix: RfidResearchGroup#189
PommyGit · May 10, 2019 · 0119e13 · 0119e13
1 parent 107b387
commit 0119e13
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/client/comms.c b/client/comms.c
@@ -613,7 +613,7 @@ int TestProxmark(void) {
 
         SendCommandNG(CMD_CAPABILITIES, NULL, 0);
         if (WaitForResponseTimeoutW(CMD_CAPABILITIES, &resp, 1000, false)) {
-            memcpy(&pm3_capabilities, resp.data.asBytes, resp.length);
+            memcpy(&pm3_capabilities, resp.data.asBytes, MIN(sizeof(capabilities_t), resp.length));
             conn.send_via_fpc_usart = pm3_capabilities.via_fpc;
             conn.uart_speed = pm3_capabilities.baudrate;
             PrintAndLogEx(INFO, "Communicating with PM3 over %s", conn.send_via_fpc_usart ? _YELLOW_("FPC UART") : _YELLOW_("USB-CDC"));