Fix: Update handling of version strings in Helm template and helpers.tpl #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bers from minor versions Signed-off-by: HJJ256 <[email protected]>
Signed-off-by: HJJ256 <[email protected]>
… numbering systems Signed-off-by: HJJ256 <[email protected]>
Signed-off-by: HJJ256 <[email protected]>
Signed-off-by: HJJ256 <[email protected]>
HJJ256
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The current master branch was not able to handle version strings like v1.30.8-eks-2d5f260 which is prevalent for AWS EKS. This causes HAMi charts installation failure as the minor version checking condition defaults to false and old parameters are used.
Also currently, scheduler imageTag needs to be set every time we have versions like v1.30.8-eks-2d5f260. However changing the definition of strippedKubeVersion in _helpers.tpl to a more general regexReplaceAll command solves this while being backwards compatible.
Which issue(s) this PR fixes:
Fixes #
#744
#791
Special notes for your reviewer: This PR will help Project HAMi to get deployed on various cloud-based Kubernetes clusters.
Does this PR introduce a user-facing change?: No