Make MUI + react-i18next peer dependencies #4113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React isn't sharing contexts across plugins + apps the way it used to (because webpack did something special? React 18 changed something?). In order to get shared contexts, Mirador (we believe) has to treat those as peer dependencies and require the installing app to provide them (like we're already doing for React etc).
... but that's slightly annoying for people who use the UMD build ("just render me a mirador"), so this PR also adds a separate Vite configuration that (should?) include all the peer dependencies so it can be used directly 🤷♂️ .