fix: H1 semantic

ProlaserGroup · Jun 23, 2023 · 8a4c986 · 8a4c986
1 parent 403b997
commit 8a4c986
Show file tree

Hide file tree

Showing 13 changed files with 14 additions and 18 deletions.
diff --git a/src/scss/custom/components/category/_header.scss b/src/scss/custom/components/category/_header.scss
@@ -1,10 +1,6 @@
 $component-name: block-category;
 
 .#{$component-name} {
-  h1 {
-    font-size: 2rem;
-  }
-
   #category-description {
     font-size: 1rem;
     color: var(--bs-gray-800);

diff --git a/templates/catalog/_partials/active_filters.tpl b/templates/catalog/_partials/active_filters.tpl
@@ -4,7 +4,7 @@
  *}
 <section id="js-active-search-filters" class="{if $activeFilters|count}active_filters{else}hide{/if}">
   {block name='active_filters_title'}
-    <h1 class="h6 {if $activeFilters|count}active-filter-title{else}d-block d-sm-none{/if}">{l s='Active filters' d='Shop.Theme.Global'}</h1>
+    <h1 class="sixth-title {if $activeFilters|count}active-filter-title{else}d-block d-sm-none{/if}">{l s='Active filters' d='Shop.Theme.Global'}</h1>
   {/block}
 
   {if $activeFilters|count}

diff --git a/templates/catalog/_partials/miniatures/category.tpl b/templates/catalog/_partials/miniatures/category.tpl
@@ -14,7 +14,7 @@
      >
     </a>
 
-    <h1 class="h4">
+    <h1 class="fourth-title">
       <a href="{$category.url}">{$category.name}</a>
     </h1>
 

diff --git a/templates/catalog/listing/product-list.tpl b/templates/catalog/listing/product-list.tpl
@@ -11,7 +11,7 @@
 {block name='content'}
 
     {block name='product_list_header'}
-      <h1 id="js-product-list-header" class="h1 mb-4">{$listing.label}</h1>
+      <h1 id="js-product-list-header" class="second-title mb-4">{$listing.label}</h1>
     {/block}
 
     {hook h="displayHeaderCategory"}

diff --git a/templates/catalog/listing/search.tpl b/templates/catalog/listing/search.tpl
@@ -13,7 +13,7 @@
 {/block}
 
 {block name='product_list_header'}
-  <h1 id="js-product-list-header" class="h4">
+  <h1 id="js-product-list-header" class="fourth-title">
     {if empty($smarty.get.s)}
       {l s='Nothing to search for' d='Shop.Theme.Catalog'}
     {else}

diff --git a/templates/catalog/product.tpl b/templates/catalog/product.tpl
@@ -38,7 +38,7 @@
 
     <div class="product__col col-lg-6 col-xl-5">
       {block name='product_header'}
-        <h1 class="h4 product__name">{block name='page_title'}{$product.name}{/block}</h1>
+        <h1 class="fourth-title product__name">{block name='page_title'}{$product.name}{/block}</h1>
       {/block}
 
       {block name='product_prices'}

diff --git a/templates/checkout/_partials/steps/checkout-step.tpl b/templates/checkout/_partials/steps/checkout-step.tpl
@@ -18,9 +18,9 @@
             role = "tabpanel"
   >
     <div class="step__title js-step-title">
-      <h1 class="step__title-left h3">
+      <p class="step__title-left third-title">
         {$title}
-      </h1>
+      </p>
       <hr />
     </div>
 

diff --git a/templates/checkout/_partials/steps/unreachable.tpl b/templates/checkout/_partials/steps/unreachable.tpl
@@ -5,9 +5,9 @@
 {block name='step'}
   <section class="step step--unreachable d-none" id="{$identifier}">
     <div class="step__title js-step-title">
-      <h1 class="step__title-left h3">
+      <p class="step__title-left third-title">
         {$title}
-      </h1>
+      </p>
     </div>
   </section>
 {/block}
diff --git a/templates/checkout/cart.tpl b/templates/checkout/cart.tpl
@@ -8,7 +8,7 @@
   <div class="cart-grid row">
     <!-- Left Block: cart product informations & shpping -->
     <div class="cart-grid__body col-lg-8">
-      <h1 class="h4">{l s='Shopping Cart' d='Shop.Theme.Checkout'}</h1>
+      <h1 class="fourth-title">{l s='Shopping Cart' d='Shop.Theme.Checkout'}</h1>
 
       <!-- cart products detailed -->
       <div class="cart-container mb-3">

diff --git a/templates/components/page-title-section.tpl b/templates/components/page-title-section.tpl
@@ -5,5 +5,5 @@
 {$componentName = 'page-title-section'}
 
 {block name='page_title_section'}
-  <h1 class="{$componentName} mb-4">{$title}</h1>
+  <h1 class="{$componentName} second-title mb-4">{$title}</h1>
 {/block}
diff --git a/templates/customer/page.tpl b/templates/customer/page.tpl
@@ -14,7 +14,7 @@
       {block name='page_header_container'}
         {block name='page_title'}
           <div class="page-header">
-            <h1 class="h4">{$smarty.block.child}</h1>
+            <h1 class="fourth-title">{$smarty.block.child}</h1>
           </div>
         {/block}
         {block name='account_link'}

diff --git a/templates/index.tpl b/templates/index.tpl
@@ -15,7 +15,7 @@
           {block name='page_header_container'}
             {block name='page_title' hide}
               <header class="page-header">
-                <h1>{$smarty.block.child}</h1>
+                <h1 class="first-title">{$smarty.block.child}</h1>
               </header>
             {/block}
           {/block}

diff --git a/templates/page.tpl b/templates/page.tpl
@@ -8,7 +8,7 @@
   {block name='page_header_container'}
     {block name='page_title'}
       <div class="page-header">
-        <h1 class="h4">{$smarty.block.child}</h1>
+        <h1 class="fourth-title">{$smarty.block.child}</h1>
       </div>
     {/block}
   {/block}
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,7 @@ @@
          >
         </a>
-        <h1 class="h4">
+        <h1 class="fourth-title">
           <a href="{$category.url}">{$category.name}</a>
         </h1>
@@ Expand Down @@