Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from frappe:main #2

Open
wants to merge 1,160 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
1160 commits
Select commit Hold shift + click to select a range
c664b12
Merge pull request #2102 from RitvikSardana/readme-images2
RitvikSardana Dec 18, 2024
1cac4d4
fix: search image
RitvikSardana Dec 18, 2024
94d8ada
Merge pull request #2103 from RitvikSardana/readme-images3
RitvikSardana Dec 18, 2024
e43eb19
chore: update readme
RitvikSardana Dec 18, 2024
38e7cc0
fix: allow export functionality for customer portal also
RitvikSardana Dec 18, 2024
edb6444
Merge pull request #2104 from RitvikSardana/list-actions
RitvikSardana Dec 18, 2024
ecd0eb3
fix: update tailwind config
RitvikSardana Dec 19, 2024
a9cef63
fix: rename Ticket List View component
RitvikSardana Dec 19, 2024
c42c031
Merge pull request #2105 from RitvikSardana/tailwind-config
RitvikSardana Dec 19, 2024
747adf2
fix: handle routes properly
RitvikSardana Dec 19, 2024
f46a733
fix(styles): article heading
RitvikSardana Dec 19, 2024
94f65de
Merge pull request #2107 from RitvikSardana/navigation
RitvikSardana Dec 19, 2024
0db7083
chore: version bump
RitvikSardana Dec 19, 2024
3a29875
Merge pull request #2108 from frappe/develop
RitvikSardana Dec 19, 2024
52ac8db
refactor: remove custom list view from knowledge base
RitvikSardana Dec 23, 2024
7922e15
refactor: escalation rules page
RitvikSardana Dec 23, 2024
d4b3e0f
fix: remove escalation rule page
RitvikSardana Dec 23, 2024
73622e3
fix: tsconfig
RitvikSardana Dec 23, 2024
26e509e
chore: code cleanup
RitvikSardana Dec 23, 2024
8f5e2da
fix: remove shitty list view
RitvikSardana Dec 23, 2024
921da06
chore: remove unnecessary pages and components
RitvikSardana Dec 23, 2024
39ab6a0
chore: update tsconfig
RitvikSardana Dec 23, 2024
5b8f0b3
refactor: notifications panel
RitvikSardana Dec 23, 2024
8fd4ad4
fix: list-view-builder api calls
RitvikSardana Dec 23, 2024
c078a67
fix: remove dependency of listManager
RitvikSardana Dec 23, 2024
f6d14cd
chore: remove unnecessary pages and components
RitvikSardana Dec 23, 2024
4153940
refactor: remove relevant functions and files of listManager
RitvikSardana Dec 23, 2024
70785f3
chore: code cleanup
RitvikSardana Dec 23, 2024
98c3335
Merge pull request #2111 from RitvikSardana/refactor-listview-2
RitvikSardana Dec 23, 2024
6a483e7
fix: only agents can access users api
RitvikSardana Dec 23, 2024
423d1aa
Merge pull request #2113 from RitvikSardana/get_users_permission
RitvikSardana Dec 23, 2024
a9b13db
fix: reload in list view builder
RitvikSardana Dec 26, 2024
91c681f
fix: only agents can access users api
RitvikSardana Dec 23, 2024
4bf42a1
fix: better ux on failure of email send
RitvikSardana Dec 30, 2024
ec07610
fix: remove rows from get_list_data
RitvikSardana Dec 30, 2024
938975f
fix: better way to set empty rows
RitvikSardana Dec 30, 2024
441d201
Merge pull request #2117 from RitvikSardana/listview-reload
RitvikSardana Dec 30, 2024
26732b8
fix: add build file for helpdesk docker image
RitvikSardana Jan 2, 2025
359f6c3
Merge pull request #2122 from RitvikSardana/docker-build
RitvikSardana Jan 2, 2025
2a9ea1a
Merge pull request #2129 from frappe/develop
RitvikSardana Jan 5, 2025
e7f8c6a
fix: update tabs component
RitvikSardana Jan 14, 2025
edf44b8
fix: update frappe-ui
RitvikSardana Jan 14, 2025
0733be5
Merge pull request #2138 from RitvikSardana/tabs-update
RitvikSardana Jan 14, 2025
60a5c2a
Merge pull request #2139 from frappe/develop
RitvikSardana Jan 14, 2025
0c11526
fix(styles): canned responses preview
RitvikSardana Jan 14, 2025
816c24f
Merge pull request #2140 from RitvikSardana/cp-preview
RitvikSardana Jan 14, 2025
6ed9a75
fix: bring back prose-f class
RitvikSardana Jan 14, 2025
4d0e2d0
refactor: knowledge base
RitvikSardana Dec 31, 2024
5591410
fix: remove all components and pages related to kb
RitvikSardana Dec 31, 2024
5fa49e7
chore: article category cleanup
RitvikSardana Dec 31, 2024
b05ca7d
fix: common variable for text editor options
RitvikSardana Jan 1, 2025
b773be0
fix: change KB router name
RitvikSardana Jan 1, 2025
2aa8236
fix: add article resource
RitvikSardana Jan 1, 2025
2ccf503
fix: add breadcrumbs in new article page
RitvikSardana Jan 2, 2025
1c48531
fix: add edit article page
RitvikSardana Jan 2, 2025
1178a85
chore: code cleanup
RitvikSardana Jan 2, 2025
c81cf3d
fix: add edit article functionality
RitvikSardana Jan 2, 2025
7164441
fix: add action buttons for article edit mode
RitvikSardana Jan 3, 2025
3394dfc
fix: edit mode in single article view
RitvikSardana Jan 6, 2025
880f660
fix: handle article delete and is dirty logic
RitvikSardana Jan 6, 2025
e35a4a6
fix: add group by functionality in list view builder
RitvikSardana Jan 6, 2025
b62d783
fix(type): Article
RitvikSardana Jan 6, 2025
b4eca79
fix: add label value in link field options of group by
RitvikSardana Jan 6, 2025
af12a38
fix: auto adjust text area height based on content
RitvikSardana Jan 6, 2025
9feabd3
fix(ui): handle article count
RitvikSardana Jan 6, 2025
8f75702
fix: handle ts config and new file for api and resources
RitvikSardana Jan 6, 2025
373f902
fix: give context of group to dropdown action buttons
RitvikSardana Jan 6, 2025
7e301e2
fix: add functionality to create new category, delete category, and c…
RitvikSardana Jan 7, 2025
0fb24dd
fix: brand logo shape
RitvikSardana Jan 10, 2025
83c24e0
feat: move to category and create category
RitvikSardana Jan 10, 2025
e2fec37
fix: move to functionality in single article view
RitvikSardana Jan 10, 2025
e04fddc
fix(styles): show indent in rows
RitvikSardana Jan 11, 2025
1239b9e
fix(ux): category dialog field
RitvikSardana Jan 11, 2025
63ce184
fix: add delete articles bulk action
RitvikSardana Jan 11, 2025
c8bebc6
fix: add category selection while creating new article
RitvikSardana Jan 12, 2025
1364839
fix(styles): category selection
RitvikSardana Jan 12, 2025
87f4a03
fix: edit mode in query params
RitvikSardana Jan 13, 2025
5b7f803
fix: rename article page file name
RitvikSardana Jan 13, 2025
4239543
fix: add customer knowledge base
RitvikSardana Jan 13, 2025
d41d598
fix: article list view page
RitvikSardana Jan 14, 2025
3ebf673
fix(ui): category view & article view
RitvikSardana Jan 14, 2025
c7c597e
fix: select field quick filter
RitvikSardana Jan 14, 2025
bc9c479
fix: add search section in new kb of customer portal
RitvikSardana Jan 14, 2025
1295582
fix: utils to copy to clipboard
RitvikSardana Jan 14, 2025
cf97d62
fix: rename search article component
RitvikSardana Jan 14, 2025
7956389
chore: code cleanup
RitvikSardana Jan 14, 2025
fecde26
fix(ui): category & article card
RitvikSardana Jan 15, 2025
7514c8f
fix(ui): scroll issue in article header
RitvikSardana Jan 15, 2025
d83388d
fix(styles): category & article card view
RitvikSardana Jan 15, 2025
b43ec15
fix: add back article feedback
RitvikSardana Jan 15, 2025
4708741
fix(styles): feedback component
RitvikSardana Jan 15, 2025
1db4f30
fix: add back telemetry to article view
RitvikSardana Jan 15, 2025
412da2a
fix: remove dead code
RitvikSardana Jan 16, 2025
26ec9b8
fix: add back scroll into section functionality in article
RitvikSardana Jan 16, 2025
6197177
chore: capitalisation of Knowledge Base string
RitvikSardana Jan 16, 2025
26598ef
refactor: isCustomerPortal variable
RitvikSardana Jan 16, 2025
f3964cd
fix: handle not allowed articles on customer portal
RitvikSardana Jan 16, 2025
b865ccf
fix(ui): icon shade
RitvikSardana Jan 16, 2025
92663b8
fix: generic way to group by with external doctype
RitvikSardana Jan 16, 2025
3bee69b
fix: better way to delete category using hooks instead of API
RitvikSardana Jan 16, 2025
2c7651e
fix: change article category doctype from tree to normal
RitvikSardana Jan 16, 2025
331bac1
fix: patch for adding 'General' article category
RitvikSardana Jan 16, 2025
de31502
fix: update frappe ui
RitvikSardana Jan 16, 2025
8ab4c73
fix: remove unnecessary child doctypes
RitvikSardana Jan 16, 2025
e20267c
fix: add validation for general article category
RitvikSardana Jan 16, 2025
1ea4bc4
chore: code cleanup
RitvikSardana Jan 16, 2025
e3bd063
chore: code cleanup
RitvikSardana Jan 17, 2025
6bc5240
fix: undefined filters issue
RitvikSardana Jan 17, 2025
897927b
perf: cache articles page
RitvikSardana Jan 17, 2025
422e56e
Update README.md (there -> their)
x-delfino Jan 17, 2025
731161a
fix: handle general category, delete article/category & move to cate…
RitvikSardana Jan 17, 2025
0d435d5
chore: code cleanup
RitvikSardana Jan 17, 2025
a458c94
fix: remove dead code
RitvikSardana Jan 17, 2025
cb12572
chore: code cleanup
RitvikSardana Jan 17, 2025
8a43b47
fix: add breadcrumb type in TS
RitvikSardana Jan 20, 2025
47c1c98
fix: add kb search results in popover
RitvikSardana Jan 20, 2025
7ede882
feat: agent portal merge categories
RitvikSardana Jan 20, 2025
d7f8d8b
fix(ui): spacing in articles and category
RitvikSardana Jan 20, 2025
c176330
fix: remove dead code
RitvikSardana Jan 20, 2025
8c61b4b
fix: remove empty style tags
RitvikSardana Jan 20, 2025
541003e
fix: remove dead code
RitvikSardana Jan 20, 2025
d054c14
fix: add telemetry for new KB
RitvikSardana Jan 20, 2025
d82f2cc
Merge pull request #2144 from x-delfino/patch-1
rmehta Jan 20, 2025
bb53885
feat: article views
RitvikSardana Jan 21, 2025
5482059
fix: copy to clipboard for article and category
RitvikSardana Jan 21, 2025
76a3883
fix: rate limit for adding feedback
RitvikSardana Jan 21, 2025
cfac08f
fix: remove rate limit on feedback
RitvikSardana Jan 21, 2025
8becae8
fix: dont show error on view exceed limit
RitvikSardana Jan 21, 2025
da8c021
fix: dont update modfied field on changing article's category
RitvikSardana Jan 21, 2025
9c16ebe
fix: remove routing warning
RitvikSardana Jan 21, 2025
6e35194
fix: update command palette
RitvikSardana Jan 21, 2025
0d7e5d4
fix: chore code cleanup
RitvikSardana Jan 21, 2025
7e35f13
fix(patch): handle case if no articles found with general category
RitvikSardana Jan 21, 2025
f60bb05
chore: code cleanup
RitvikSardana Jan 21, 2025
03909a8
fix: remove status field form article category doctype
RitvikSardana Jan 21, 2025
5c6793b
Merge pull request #2124 from RitvikSardana/kb-refactor
RitvikSardana Jan 21, 2025
1f11342
fix: update tab component for mobile view
RitvikSardana Jan 21, 2025
3f59822
Merge pull request #2145 from RitvikSardana/mobile-tab-component
RitvikSardana Jan 21, 2025
e9a8274
chore: update readme
RitvikSardana Jan 21, 2025
94a45b5
fix: rename routing param
RitvikSardana Jan 22, 2025
ac8f1b1
Merge pull request #2146 from RitvikSardana/router-naming
RitvikSardana Jan 22, 2025
3ff4c6d
fix: telemetry enabled fix
RitvikSardana Jan 22, 2025
d893917
Merge pull request #2147 from RitvikSardana/telemetry-fix
RitvikSardana Jan 22, 2025
5a9e99f
fix(type): add typesafety to ticket agent activities
RitvikSardana Jan 23, 2025
514b4b3
fix(styles): ticket overflow
RitvikSardana Jan 23, 2025
e786935
fix: use count to get list of total count of rows in listview
RitvikSardana Jan 23, 2025
f5a417e
feat: edit comment
RitvikSardana Jan 23, 2025
80b59cb
fix(ux): focus on comment if editable true
RitvikSardana Jan 23, 2025
b9ee222
fix(ui): typography in comment activity
RitvikSardana Jan 23, 2025
b847ba2
feat: attachments in comments
RitvikSardana Jan 23, 2025
9fc4674
fix: notifications seen all ticket not found
RitvikSardana Jan 23, 2025
274806f
fix: hide notifcations tab in mobile view of customer portal
RitvikSardana Jan 24, 2025
4980456
chore: code cleanup
RitvikSardana Jan 24, 2025
5ca5f7c
chore: bump actions/cache to v4
barredterra Jan 27, 2025
9901118
Merge pull request #2154 from barredterra/develop
RitvikSardana Jan 27, 2025
7440b23
chore: code cleanup
RitvikSardana Jan 28, 2025
030cd8b
fix: hide attachments while editing
RitvikSardana Jan 28, 2025
9ecf7c4
Merge pull request #2151 from RitvikSardana/comment-box-refactor
RitvikSardana Jan 28, 2025
5c2788a
Merge pull request #2156 from frappe/develop
RitvikSardana Jan 28, 2025
f9ed8f4
fix: duplicate entry while installing helpdesk
RitvikSardana Jan 29, 2025
4051665
chore: code cleanup
RitvikSardana Jan 29, 2025
008ab90
Merge pull request #2157 from RitvikSardana/duplicate-install
RitvikSardana Jan 29, 2025
c4e3748
Merge pull request #2158 from frappe/develop
RitvikSardana Jan 29, 2025
aad13b0
chore: bump frappe-ui version
RitvikSardana Jan 29, 2025
28d960d
Merge pull request #2159 from RitvikSardana/bump-fui
RitvikSardana Jan 29, 2025
6b2b357
fix(ux): shortcut for submiting mail
RitvikSardana Jan 30, 2025
238bd90
fix(ux): persist different ticket data in local storage
RitvikSardana Jan 30, 2025
94cb074
fix: icon color in text editor
RitvikSardana Jan 30, 2025
2639ebb
fix: add search functionality single team page
RitvikSardana Jan 30, 2025
d724b4c
fix: remove data from local storage
RitvikSardana Jan 30, 2025
e0a8653
fix: add shortcut for customer side also
RitvikSardana Jan 30, 2025
35f1da6
chore: code cleanup
RitvikSardana Jan 30, 2025
83057cb
Merge pull request #2160 from RitvikSardana/keyboard-shortcut
RitvikSardana Jan 30, 2025
987b6f1
refactor: ticket list view
RitvikSardana Jan 31, 2025
ff2f193
fix: badge color
RitvikSardana Feb 1, 2025
1ac35bd
chore: code cleanup
RitvikSardana Feb 2, 2025
6e0ed1a
fix: add support for apply filters on click in common list view
RitvikSardana Feb 3, 2025
2410991
chore: code clean up
RitvikSardana Feb 3, 2025
f5239a1
chore: code cleanup
RitvikSardana Feb 3, 2025
b12c696
fix: handle case if no columnConfig is found
RitvikSardana Feb 3, 2025
57377b1
fix(ui): p tag size
RitvikSardana Feb 3, 2025
a2e4807
feat: add column layout modification in general list view
RitvikSardana Feb 4, 2025
f828a46
fix: multiple avatar component props handeling
RitvikSardana Feb 5, 2025
bf8c533
fix: add support for rating component in filter & use the generic lis…
RitvikSardana Feb 5, 2025
d8f11cd
fix: add support for bulk delete and export tickets
RitvikSardana Feb 6, 2025
a037ab9
chore: code cleanup
RitvikSardana Feb 6, 2025
1c23f29
fix: reply to email option
RitvikSardana Feb 6, 2025
4929cc1
fix: empty state of ticket list view
RitvikSardana Feb 6, 2025
928d1cb
fix: listview should have atleast one column
RitvikSardana Feb 6, 2025
1014016
fix: show column setting conditionally
RitvikSardana Feb 6, 2025
88831f6
fix: remove olde ticket list view
RitvikSardana Feb 6, 2025
79d7528
fix: change file structure of tickets
RitvikSardana Feb 6, 2025
26614d1
fix: ticket composable
RitvikSardana Feb 6, 2025
6ed9250
chore: code cleanup
RitvikSardana Feb 10, 2025
4e4a7e5
fix: add view settings doctype
RitvikSardana Feb 12, 2025
a10c34d
fix: handle creation of new view
RitvikSardana Feb 12, 2025
d812962
fix: update naming series & more function to filter views
RitvikSardana Feb 12, 2025
e2c4c4e
fix: add create view modal
RitvikSardana Feb 12, 2025
4d946bd
fix: add icon picker in ViewModal
RitvikSardana Feb 12, 2025
5a4055e
fix: handle dialog primary action
RitvikSardana Feb 12, 2025
b35dd72
fix: render emojis in UI
RitvikSardana Feb 12, 2025
99759d1
fix: add standard fields in filters
RitvikSardana Feb 12, 2025
fdf67ed
chore: code cleanup
RitvikSardana Feb 12, 2025
44e418e
fix: proper working flow of new view creation
RitvikSardana Feb 13, 2025
cce67ee
fix: update existing views
RitvikSardana Feb 14, 2025
65fe2b9
fix: multiple get_list calls for HD View
RitvikSardana Feb 14, 2025
eec2114
fix: support for customer portal
RitvikSardana Feb 14, 2025
d8fb18e
fix: show pinned and public views on sidebar
RitvikSardana Feb 14, 2025
4802aec
fix: global current view state
RitvikSardana Feb 17, 2025
de57443
fix: show nested dropdown in custom view
RitvikSardana Feb 17, 2025
61d5c39
fix: add functionality for each custom view
RitvikSardana Feb 18, 2025
48966a7
fix: handle default custom view for each page
RitvikSardana Feb 19, 2025
55319e5
chore: code cleanup
RitvikSardana Feb 19, 2025
60f3eed
fix: @me support in filters
RitvikSardana Feb 19, 2025
146b442
fix: add AgentManager role in HD
RitvikSardana Feb 19, 2025
c07c056
fix: support for customer portal
RitvikSardana Feb 19, 2025
8fe086b
fix: only managers can make changes to public view
RitvikSardana Feb 19, 2025
4d939cf
fix: duplicate view + confirmation dialog on deleting view
RitvikSardana Feb 20, 2025
685f1bc
fix: remove version from context
RitvikSardana Feb 20, 2025
827981f
fix(styles): kb public and canned response
RitvikSardana Feb 20, 2025
bff4590
chore: code cleanup
RitvikSardana Feb 20, 2025
a927727
chore: code cleanup
RitvikSardana Feb 20, 2025
51058a6
fix: dont remve view user if making public view to private
RitvikSardana Feb 20, 2025
42cd3cd
fix: delete ticket access to only Agent Manager
RitvikSardana Feb 20, 2025
916ce9f
chore: code cleanup
RitvikSardana Feb 20, 2025
7fc6df5
fix: move frappe mail to last
RitvikSardana Feb 20, 2025
79fd004
fix: like operator for assigned to field
RitvikSardana Feb 20, 2025
3076154
fix: condition for default view
RitvikSardana Feb 20, 2025
034a7a7
fix: show views in mobile sidebar
RitvikSardana Feb 20, 2025
239509b
fix(styles): mobile sidebar
RitvikSardana Feb 20, 2025
a044210
Merge pull request #2162 from RitvikSardana/ticket-listview-refactor
RitvikSardana Feb 20, 2025
ed8223f
fix: change search complete to link component
RitvikSardana Feb 20, 2025
034437b
fix(styles): view bread crumbs
RitvikSardana Feb 20, 2025
04b0eb0
Merge pull request #2178 from RitvikSardana/styles-custom-view
RitvikSardana Feb 20, 2025
179328d
fix: emit link field event and value
RitvikSardana Feb 21, 2025
034abbc
Merge pull request #2179 from RitvikSardana/link-field-change
RitvikSardana Feb 21, 2025
d7c944f
fix: use route-link instead of div in LVB
RitvikSardana Feb 21, 2025
11f81e3
chore: code cleanup
RitvikSardana Feb 21, 2025
84ad3df
Merge pull request #2182 from RitvikSardana/listview-click-navigation
RitvikSardana Feb 21, 2025
5cf1a7c
fix: path of mobile ticket component
RitvikSardana Feb 23, 2025
4301cf9
Merge pull request #2183 from RitvikSardana/mobile-ticket
RitvikSardana Feb 23, 2025
a88aab0
fix: update limit of view resource
RitvikSardana Feb 24, 2025
d3e3094
fix: fetch more views
RitvikSardana Feb 24, 2025
b898257
fix: confirmation msg for making a view private
RitvikSardana Feb 25, 2025
d76f616
fix: confirmation dialog for updating public view
RitvikSardana Feb 25, 2025
83e18d7
fix: breadcrumbs of view in single ticket
RitvikSardana Feb 28, 2025
dcdd184
Merge pull request #2187 from RitvikSardana/view-confirmation
RitvikSardana Feb 28, 2025
b5fc653
fix: ignore duplicate while installing HD
RitvikSardana Feb 28, 2025
cb5d158
Merge pull request #2188 from RitvikSardana/duplicate-installation
RitvikSardana Feb 28, 2025
5cd2a3f
Merge pull request #2189 from frappe/develop
RitvikSardana Feb 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: breadcrumbs of view in single ticket
  • Loading branch information
RitvikSardana committed Feb 28, 2025
commit 83e18d7b02294dc0d12c15ae60fdeef6b3d8d6e7
21 changes: 21 additions & 0 deletions desk/src/components/Icon.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<template>
<div v-if="isEmoji(icon)" v-bind="$attrs">
{{ icon }}
</div>
<FeatherIcon
v-else-if="typeof icon == 'string'"
:name="icon"
v-bind="$attrs"
/>
<component v-else :is="icon" v-bind="$attrs" />
</template>
<script setup>
import { isEmoji } from "@/utils";

const props = defineProps({
icon: {
type: [String, Object],
required: true,
},
});
</script>
21 changes: 4 additions & 17 deletions desk/src/components/ListViewBuilder.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
getRowRoute: (row) => ({
name: options.rowRoute?.name,
params: { [options.rowRoute?.prop]: row.name },
query: { view: route.query?.view },
}),
emptyState,
}"
Expand Down Expand Up @@ -397,7 +398,7 @@ function listCell(column: any, row: any, item: any, idx: number) {
return h(MultipleAvatar, {
avatars: item,
hideName: true,
class: "flex items-center",
class: "flex items-center truncate",
});
}
if (column.type === "Rating") {
Expand Down Expand Up @@ -523,7 +524,6 @@ function handlePageLength(count: number, loadMore: boolean = false) {
}

function handleViewUpdate() {
const isPublicView = findCurrentView()?.public;
const view = {
filters: JSON.stringify(defaultParams.filters),
columns: JSON.stringify(defaultParams.columns),
Expand All @@ -534,21 +534,8 @@ function handleViewUpdate() {
route_name: route.name,
is_customer_portal: options.value.isCustomerPortal,
};
if (!isPublicView) {
updateView(view, () => {
isViewUpdated.value = false;
});
return;
}
confirmDialog({
title: "Update Public View?",
message: `Updating public view will change the view for all users. Do you want to continue?`,
onConfirm: ({ hideDialog }: { hideDialog: Function }) => {
hideDialog();
updateView(view, () => {
isViewUpdated.value = false;
});
},
updateView(view, () => {
isViewUpdated.value = false;
});
}

Expand Down
1 change: 1 addition & 0 deletions desk/src/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ export { default as AutocompleteNew } from "./frappe-ui/Autocomplete.vue";
export { default as Link } from "./frappe-ui/Link.vue";
export { default as ListViewBuilder } from "./ListViewBuilder.vue";
export { default as Section } from "./Section.vue";
export { default as Icon } from "./Icon.vue";
31 changes: 28 additions & 3 deletions desk/src/pages/ticket/TicketAgent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,15 @@
<div class="flex flex-col">
<LayoutHeader v-if="ticket.data">
<template #left-header>
<Breadcrumbs :items="breadcrumbs" class="breadcrumbs" />
<Breadcrumbs :items="breadcrumbs" class="breadcrumbs">
<template #prefix="{ item }">
<Icon
v-if="item.icon"
:icon="item.icon"
class="mr-1 h-4 flex items-center justify-center self-center"
/>
</template>
</Breadcrumbs>
</template>
<template #right-header>
<CustomActions
Expand Down Expand Up @@ -125,6 +133,7 @@

<script setup lang="ts">
import { computed, ref, h, watch, onMounted, onUnmounted, provide } from "vue";
import { useRoute } from "vue-router";
import { useStorage } from "@vueuse/core";
import {
Breadcrumbs,
Expand All @@ -142,6 +151,7 @@ import {
MultipleAvatar,
AssignmentModal,
CommunicationArea,
Icon,
} from "@/components";
import { TicketAgentActivities, TicketAgentSidebar } from "@/components/ticket";
import {
Expand All @@ -153,8 +163,10 @@ import {
import { socket } from "@/socket";
import { useTicketStatusStore } from "@/stores/ticketStatus";
import { useUserStore } from "@/stores/user";
import { createToast, setupCustomActions } from "@/utils";
import { TabObject, TicketTab } from "@/types";
import { createToast, getIcon, setupCustomActions } from "@/utils";
import { TabObject, TicketTab, View } from "@/types";
import { useView } from "@/composables/useView";
import { ComputedRef } from "vue";

const ticketStatusStore = useTicketStatusStore();
const { getUser } = useUserStore();
Expand All @@ -175,6 +187,9 @@ watch(
ticket.reload();
}
);
const route = useRoute();
const { findView } = useView("HD Ticket");

provide("communicationArea", communicationAreaRef);

let storage = useStorage("ticket_agent", {
Expand Down Expand Up @@ -218,6 +233,16 @@ function updateField(name, value, callback = () => {}) {

const breadcrumbs = computed(() => {
let items = [{ label: "Tickets", route: { name: "TicketsAgent" } }];
if (route.query.view) {
const currView: ComputedRef<View> = findView(route.query.view as string);
if (currView) {
items.push({
label: currView.value.label,
icon: getIcon(currView.value.icon),
route: { name: "TicketsAgent", query: { view: currView.value.name } },
});
}
}
items.push({
label: ticket.data?.subject,
onClick: () => {
Expand Down
2 changes: 1 addition & 1 deletion helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ def default_list_data(show_customer_portal_fields=False):
"label": "Assigned To",
"type": "MultipleAvatar",
"key": "_assign",
"width": "5em",
"width": "8rem",
},
{
"label": "Customer",
Expand Down