Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed bossbar title to TextComponent instead of String #435

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

leobeg
Copy link
Contributor

@leobeg leobeg commented Dec 30, 2024

Description

This PR migrates from the String implementation to the Vanilla TextComponent

Testing

Open up the game and use /bossbar add minecraft:test {"text":"Pumpkin","color":"gold"}
Use /bossbar set minecraft:test players @a
You should now see the colored bossbar

image

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test
  • I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

@Snowiiii
Copy link
Member

Looks good, I have nothing to complain about. Thank you @leobeg 👍. Now we can have cool Colors and more 🌈

@Snowiiii Snowiiii merged commit 72a9670 into Pumpkin-MC:master Dec 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants