Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* bandit/cli/main.py: Set log level to ERROR if -q option is passed. #941

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

* bandit/cli/main.py: Set log level to ERROR if -q option is passed. #941

wants to merge 4 commits into from

Conversation

bje-
Copy link

@bje- bje- commented Aug 13, 2022

Fixes #907

@sigmavirus24
Copy link
Member

I think the conversation on that issue is misinterpreting the documentation. I thought -q was repeatable. If it's repeated a second time, I would expect us to up the logging level to error (e.g., -qq) but I'm not sure I agree with this change as it stands. Especially with the log message that you seem to be taking issue with

@bje-
Copy link
Author

bje- commented Aug 15, 2022

You're right. I think this is a better solution.

CTimmerman
CTimmerman reviewed Aug 20, 2022
View reviewed changes
Copy link

@CTimmerman CTimmerman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think -d conflicts with -q because line 313 says parser instead of group.

@bje-
Copy link
Author

bje- commented Oct 14, 2022

I think -d conflicts with -q because line 313 says parser instead of group.

No, -q and -v are in a group of mutually exclusive options. It's fine as it is.

@bje-
Copy link
Author

bje- commented Mar 12, 2023 •
edited
Loading

How can I progress with getting this merged, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CTimmerman CTimmerman CTimmerman approved these changes

@ericwb ericwb Awaiting requested review from ericwb ericwb is a code owner

@lukehinds lukehinds Awaiting requested review from lukehinds lukehinds is a code owner

@sigmavirus24 sigmavirus24 Awaiting requested review from sigmavirus24 sigmavirus24 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to find qualified name
3 participants
@bje- @sigmavirus24 @CTimmerman