Fix B026 on attributes (#420)

PyCQA · Nov 3, 2023 · 907e0dd · 907e0dd
1 parent 78d08a7
commit 907e0dd
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/README.rst b/README.rst
@@ -338,6 +338,12 @@ MIT
 Change Log
 ----------
 
+Unreleased
+~~~~~~~~~~
+
+* B026: Fix bug where the check was not triggered for calls where the callee
+  is an attribute
+
 23.9.16
 ~~~~~~~
 

diff --git a/bugbear.py b/bugbear.py
@@ -440,8 +440,7 @@ def visit_Call(self, node):
                 ):
                     self.errors.append(B010(node.lineno, node.col_offset))
 
-            self.check_for_b026(node)
-
+        self.check_for_b026(node)
         self.check_for_b028(node)
         self.check_for_b034(node)
         self.check_for_b905(node)

diff --git a/tests/b026.py b/tests/b026.py
@@ -18,3 +18,4 @@ def foo(bar, baz, bam):
 foo(bar="bar", baz="baz", bam="bam", *[])
 foo(bam="bam", *["bar"], *["baz"])
 foo(*["bar"], bam="bam", *["baz"])
+foo.bar(bam="bam", *["bar"])
diff --git a/tests/test_bugbear.py b/tests/test_bugbear.py
@@ -415,6 +415,7 @@ def test_b026(self):
                 B026(19, 15),
                 B026(19, 25),
                 B026(20, 25),
+                B026(21, 19),
             ),
         )