-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.12 to CI, tox and metadata; use latest black and flake8 #3737
Conversation
src/pyramid/config/adapters.py
Outdated
@@ -80,7 +80,7 @@ def _derive_predicate(self, predicate): | |||
|
|||
if eventonly(predicate): | |||
|
|||
def derived_predicate(*arg): | |||
def derived_predicate(*arg): # noqa: F811 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to fix the lint error rather than ignoring it. Maybe:
if not eventonly(predicate):
return predicate
def derived_predicate(*arg):
return predicate(arg[0])
return derived_predicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, went for else
clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to code and CI, would you please scan the documentation for Python support? I suspect searching for python 3
or 3.11
will turn up a few instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I approve the docs stuff only.
Signed-off-by: Ievgen Popovych <[email protected]>
Signed-off-by: Ievgen Popovych <[email protected]>
5cf5934
to
ca73259
Compare
Done. Should we drop Python 3.7? |
Oh, sorry about the force-push, didn't expect you'd catch this so fast :) |
No description provided.