Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.12 to CI, tox and metadata; use latest black and flake8 #3737

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

Jmennius
Copy link
Contributor

No description provided.

@@ -80,7 +80,7 @@ def _derive_predicate(self, predicate):

if eventonly(predicate):

def derived_predicate(*arg):
def derived_predicate(*arg): # noqa: F811
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to fix the lint error rather than ignoring it. Maybe:

if not eventonly(predicate):
    return predicate

def derived_predicate(*arg):
     return predicate(arg[0])

return derived_predicate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, went for else clause.

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to code and CI, would you please scan the documentation for Python support? I suspect searching for python 3 or 3.11 will turn up a few instances.

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I approve the docs stuff only.

@Jmennius Jmennius force-pushed the support-python-3.12 branch from 5cf5934 to ca73259 Compare November 30, 2023 09:48
@Jmennius
Copy link
Contributor Author

In addition to code and CI, would you please scan the documentation for Python support? I suspect searching for python 3 or 3.11 will turn up a few instances.

Done.
At this point, I would think that we may need a release notes/changes update as well? But I'm a bit confused about that because of difference in 2.0-branch and main.

Should we drop Python 3.7?

@Jmennius
Copy link
Contributor Author

Thank you! I approve the docs stuff only.

Oh, sorry about the force-push, didn't expect you'd catch this so fast :)

@mmerickel mmerickel merged commit 165b16c into Pylons:main Jan 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants