Xbar-W reader writer options processing re-work #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wxbar_config_rework
…rior to wheel spinning
…xhat-w reader/writer.
…wxbar_config_rework
bknueven
approved these changes
Feb 14, 2025
| @@ -958,32 +958,12 @@ def tracking_args(self): | |||
| domain=int, | |||
| default=0) | |||
|
|
|||
|
|
|||
| def wxbar_read_write_args(self): | |||
There was a problem hiding this comment.
Is this idea that this method would eventually go away so that generic_cylinders or any other clients directly call the add_options_to_config on the module?
| assert 'cfg' in ph.options | ||
| self.cfg = ph.options['cfg'] | ||
| if self.cfg.get("W_and_xbar_reader") is None or not self.cfg.W_and_xbar_reader: | ||
| self.not_active = True |
There was a problem hiding this comment.
Since this is new code, I'll just say I don't like negative bools (i.e., the flag should be called active).
Not a reason to hold up this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended as an exemplar for improving options processing and reading in mpisppy.
Objective is to move options definition and processing into "leaf" classes, to improve encapsulation.
This PR only does this for XBar-W reader/writer extensions, as a concise place to start.
Also actually makes use of these extensions in generic_cylinders.py - previously the options were specified, but never used.