Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.

Game 2048 #460

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Game 2048 #460

wants to merge 3 commits into from

Conversation

Jamyw7g
Copy link
Contributor

@Jamyw7g Jamyw7g commented Sep 20, 2021

Description

A game written in Python without any Third-party Package.

Replace issue_no in the above line, with the issue related to this PR.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

@YahelB05
Copy link

Hello @Jamyw7g !

I like to see your code improvements, but I'm missing some in-code function documentation and python conventions.

How to improve:

  • Space up the functions from each other by 2 blank lines
  • Document every needed function using 'docstring'
  • Make sure you follow the rest of python PEP rules

How it would make it better:

  • More readable
  • Easy for others to be able to understand the code and help/contribute

Good Luck, Happy Coding 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants