FIX:open cut gizmo check selection.is_empty() again

jira: STUDIO-8310 Change-Id: I5265ccb54345595fefb9a3775f45e96be55cc9dd
QINGHLS · Oct 15, 2024 · 0faf8d5 · 0faf8d5
1 parent 9e313d5
commit 0faf8d5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/slic3r/GUI/Gizmos/GLGizmoAdvancedCut.cpp b/src/slic3r/GUI/Gizmos/GLGizmoAdvancedCut.cpp
@@ -479,6 +479,11 @@ void GLGizmoAdvancedCut::on_set_state()
 
     // Reset m_cut_z on gizmo activation
     if (get_state() == On) {
+        const Selection &selection = m_parent.get_selection();
+        if (selection.is_empty()) {//check selection again
+            close();
+            return;
+        }
         m_hover_id           = -1;
         m_connectors_editing = false;
 
@@ -515,6 +520,13 @@ void GLGizmoAdvancedCut::on_set_state()
     }
 }
 
+void GLGizmoAdvancedCut::close()
+{//close gizmo == open it again
+    auto &mng = m_parent.get_gizmos_manager();
+    if (mng.get_current_type() == GLGizmosManager::Cut)
+        mng.open_gizmo(GLGizmosManager::Cut);
+}
+
 bool GLGizmoAdvancedCut::on_is_activable() const
 {
     const Selection &selection  = m_parent.get_selection();

diff --git a/src/slic3r/GUI/Gizmos/GLGizmoAdvancedCut.hpp b/src/slic3r/GUI/Gizmos/GLGizmoAdvancedCut.hpp
@@ -229,6 +229,7 @@ class GLGizmoAdvancedCut : public GLGizmoRotate3D
     virtual std::string on_get_name() const;
     virtual std::string on_get_name_str() override { return "Cut"; }
     virtual void on_set_state();
+    void         close();
     virtual bool on_is_activable() const;
     virtual CommonGizmosDataID on_get_requirements() const override;
     virtual void on_start_dragging() override;