forked from wildfly/wildfly
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WFLY-822 Make sure the deployment's classloader is set as TCCL during…
… the lifecycle of a MBean instance
- Loading branch information
1 parent
10fd9fd
commit c1a6392
Showing
14 changed files
with
389 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...est/java/org/jboss/as/test/integration/sar/context/classloader/ClassAInSarDeployment.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * JBoss, Home of Professional Open Source. | ||
| * Copyright 2013, Red Hat, Inc., and individual contributors | ||
| * as indicated by the @author tags. See the copyright.txt file in the | ||
| * distribution for a full listing of individual contributors. | ||
| * | ||
| * This is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU Lesser General Public License as | ||
| * published by the Free Software Foundation; either version 2.1 of | ||
| * the License, or (at your option) any later version. | ||
| * | ||
| * This software is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public | ||
| * License along with this software; if not, write to the Free | ||
| * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA | ||
| * 02110-1301 USA, or see the FSF site: http://www.fsf.org. | ||
| */ | ||
|
|
||
| package org.jboss.as.test.integration.sar.context.classloader; | ||
|
|
||
| /** | ||
| * @author: Jaikiran Pai | ||
| */ | ||
| public class ClassAInSarDeployment { | ||
| } |
29 changes: 29 additions & 0 deletions
29
...est/java/org/jboss/as/test/integration/sar/context/classloader/ClassBInSarDeployment.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * JBoss, Home of Professional Open Source. | ||
| * Copyright 2013, Red Hat, Inc., and individual contributors | ||
| * as indicated by the @author tags. See the copyright.txt file in the | ||
| * distribution for a full listing of individual contributors. | ||
| * | ||
| * This is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU Lesser General Public License as | ||
| * published by the Free Software Foundation; either version 2.1 of | ||
| * the License, or (at your option) any later version. | ||
| * | ||
| * This software is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public | ||
| * License along with this software; if not, write to the Free | ||
| * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA | ||
| * 02110-1301 USA, or see the FSF site: http://www.fsf.org. | ||
| */ | ||
|
|
||
| package org.jboss.as.test.integration.sar.context.classloader; | ||
|
|
||
| /** | ||
| * @author: Jaikiran Pai | ||
| */ | ||
| public class ClassBInSarDeployment { | ||
| } |
29 changes: 29 additions & 0 deletions
29
...est/java/org/jboss/as/test/integration/sar/context/classloader/ClassCInSarDeployment.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * JBoss, Home of Professional Open Source. | ||
| * Copyright 2013, Red Hat, Inc., and individual contributors | ||
| * as indicated by the @author tags. See the copyright.txt file in the | ||
| * distribution for a full listing of individual contributors. | ||
| * | ||
| * This is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU Lesser General Public License as | ||
| * published by the Free Software Foundation; either version 2.1 of | ||
| * the License, or (at your option) any later version. | ||
| * | ||
| * This software is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public | ||
| * License along with this software; if not, write to the Free | ||
| * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA | ||
| * 02110-1301 USA, or see the FSF site: http://www.fsf.org. | ||
| */ | ||
|
|
||
| package org.jboss.as.test.integration.sar.context.classloader; | ||
|
|
||
| /** | ||
| * @author: Jaikiran Pai | ||
| */ | ||
| public class ClassCInSarDeployment { | ||
| } |
29 changes: 29 additions & 0 deletions
29
...est/java/org/jboss/as/test/integration/sar/context/classloader/ClassDInSarDeployment.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * JBoss, Home of Professional Open Source. | ||
| * Copyright 2013, Red Hat, Inc., and individual contributors | ||
| * as indicated by the @author tags. See the copyright.txt file in the | ||
| * distribution for a full listing of individual contributors. | ||
| * | ||
| * This is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU Lesser General Public License as | ||
| * published by the Free Software Foundation; either version 2.1 of | ||
| * the License, or (at your option) any later version. | ||
| * | ||
| * This software is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public | ||
| * License along with this software; if not, write to the Free | ||
| * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA | ||
| * 02110-1301 USA, or see the FSF site: http://www.fsf.org. | ||
| */ | ||
|
|
||
| package org.jboss.as.test.integration.sar.context.classloader; | ||
|
|
||
| /** | ||
| * @author: Jaikiran Pai | ||
| */ | ||
| public class ClassDInSarDeployment { | ||
| } |
106 changes: 106 additions & 0 deletions
106
...rc/test/java/org/jboss/as/test/integration/sar/context/classloader/MBeanTCCLTestCase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| package org.jboss.as.test.integration.sar.context.classloader; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| import javax.management.MBeanServerConnection; | ||
| import javax.management.ObjectName; | ||
| import javax.management.remote.JMXConnectorFactory; | ||
|
|
||
| import org.jboss.arquillian.container.test.api.Deployment; | ||
| import org.jboss.arquillian.container.test.api.RunAsClient; | ||
| import org.jboss.arquillian.junit.Arquillian; | ||
| import org.jboss.as.arquillian.api.ContainerResource; | ||
| import org.jboss.as.arquillian.container.ManagementClient; | ||
| import org.jboss.as.test.integration.sar.context.classloader.mbean.MBeanInAModuleService; | ||
| import org.jboss.as.test.integration.sar.context.classloader.mbean.MBeanInAModuleServiceMBean; | ||
| import org.jboss.logging.Logger; | ||
| import org.jboss.shrinkwrap.api.Archive; | ||
| import org.jboss.shrinkwrap.api.ShrinkWrap; | ||
| import org.jboss.shrinkwrap.api.spec.EnterpriseArchive; | ||
| import org.jboss.shrinkwrap.api.spec.JavaArchive; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| /** | ||
| * Tests that the MBean instance lifecycle has the correct TCCL set. The TCCL is expected to be the classloader of the deployment through which the MBean was deployed. | ||
| * | ||
| * @author: Jaikiran Pai | ||
| * @see https://issues.jboss.org/browse/WFLY-822 | ||
| */ | ||
| @RunWith(Arquillian.class) | ||
| @RunAsClient | ||
| public class MBeanTCCLTestCase { | ||
|
|
||
| private static final Logger logger = Logger.getLogger(MBeanTCCLTestCase.class); | ||
|
|
||
| private static final String EAR_NAME = "tccl-mbean-test-app"; | ||
| private static final String SAR_NAME = "tccl-mbean-test-sar"; | ||
|
|
||
| @ContainerResource | ||
| private ManagementClient managementClient; | ||
|
|
||
| /** | ||
| * .ear | ||
| * | | ||
| * |---- META-INF/jboss-deployment-structure.xml | ||
| * | | ||
| * |---- .sar | ||
| * | | | ||
| * | |--- META-INF/jboss-service.xml (deploys the MBean whose class resides in a separate JBoss module) | ||
| * | | | ||
| * | |--- ClassA, ClassB, ClassC, ClassD (all of which will be attempted to be loaded from the MBean class which resides in a different JBoss module than this deployment) | ||
| * | | ||
| * | | ||
| * |---- .jar (configured as a JBoss Module in jboss-deployment-structure.xml of the .ear) | ||
| * | | | ||
| * | |---- MBean class (which relies on TCCL to load the classes present in the .sar deployment) | ||
| * | ||
| * @return | ||
| */ | ||
| @Deployment | ||
| public static Archive createDeployment() { | ||
| // create a .sar which will contain a jboss-service.xml. The actual MBean class will reside in a module which will be added as a dependency on the .sar | ||
| final JavaArchive sar = ShrinkWrap.create(JavaArchive.class, SAR_NAME + ".sar"); | ||
| // add the jboss-service.xml to the META-INF of the .sar | ||
| sar.addAsManifestResource(MBeanInAModuleService.class.getPackage(), "tccl-test-service.xml", "jboss-service.xml"); | ||
| // add some (dummy) classes to the .sar. These classes will then be attempted to be loaded from the MBean class (which resides in a module) | ||
| sar.addClasses(ClassAInSarDeployment.class, ClassBInSarDeployment.class, ClassCInSarDeployment.class, ClassDInSarDeployment.class); | ||
|
|
||
| // now create a plain .jar containing the MBean class. This jar will be configured as a JBoss Module, in the jboss-deployment-structure.xml of the .ear to which this | ||
| // .jar will be added | ||
| final JavaArchive jar = ShrinkWrap.create(JavaArchive.class, "jar-containing-mbean-class.jar"); | ||
| jar.addClasses(MBeanInAModuleService.class, MBeanInAModuleServiceMBean.class); | ||
|
|
||
| // create the .ear with the .sar and the .jar and the jboss-deployment-structure.xml | ||
| final EnterpriseArchive ear = ShrinkWrap.create(EnterpriseArchive.class, EAR_NAME + ".ear"); | ||
| ear.addAsModule(sar); | ||
| ear.addAsModule(jar); | ||
| ear.addAsManifestResource(MBeanTCCLTestCase.class.getPackage(), "jboss-deployment-structure.xml", "jboss-deployment-structure.xml"); | ||
|
|
||
| logger.info("created deployment: " + ear.toString(true)); | ||
| return ear; | ||
| } | ||
|
|
||
| /** | ||
| * Tests the MBean was deployed successfully and can be invoked. The fact that the MBean deployed successfully is a sign that the TCCL access from within the MBean code, worked fine | ||
| * | ||
| * @throws Exception | ||
| */ | ||
| @Test | ||
| public void testTCCLInMBeanInvocation() throws Exception { | ||
| final MBeanServerConnection mBeanServerConnection = this.getMBeanServerConnection(); | ||
| final ObjectName mbeanObjectName = new ObjectName("wildfly:name=tccl-test-mbean"); | ||
| final int num1 = 3; | ||
| final int num2 = 4; | ||
| // invoke the operation on MBean | ||
| final Integer sum = (Integer) mBeanServerConnection.invoke(mbeanObjectName, "add", new Object[]{num1, num2}, new String[]{Integer.TYPE.getName(), Integer.TYPE.getName()}); | ||
| Assert.assertEquals("Unexpected return value from MBean: " + mbeanObjectName, num1 + num2, (int) sum); | ||
| } | ||
|
|
||
| private MBeanServerConnection getMBeanServerConnection() throws IOException { | ||
| return JMXConnectorFactory.connect(managementClient.getRemoteJMXURL()).getMBeanServerConnection(); | ||
|
|
||
| } | ||
|
|
||
| } |
Oops, something went wrong.