Improves Extensions.TryConvert to avoid test by exception #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchandschuh
approved these changes
Jun 12, 2018
Instead of letting `PyObject.AsManagedObject` throw an exception because the types do not match, we check whether the target type is assignable from the python object type. This PR fixes PR #2102 that caused a bug in Symbol[] convertion. Unit tests were added to test all changes.
AlexCatarino
force-pushed
the
bug-2091-indicator-register-throws
branch
from
5b0c197 to
a4233c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of letting
PyObject.AsManagedObjectthrow an exception because the types do not match, we check whether the target type is assignable from the python object type.Related Issue
This PR fixes PR #2102 that caused a bug in Symbol[] convertion.
Closes #2091 and fixes #2102
Requires Documentation Change
No.
How Has This Been Tested?
Unit tests were added to test all changes.
Types of changes
Checklist:
bug-<issue#>-<descriptionorfeature-<issue#>-<description>