[Draft] Add interface for arch-specific vCPU #1132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chl337
force-pushed
the
WIP_KVMvcpu_arch_concept
branch
2 times, most recently
from
ccb0881 to
9e3bff4
Compare
Fix complilation errors caused by refactoring.
chl337
force-pushed
the
WIP_KVMvcpu_arch_concept
branch
from
9e3bff4 to
802b0cf
Compare
chl337
force-pushed
the
WIP_KVMvcpu_arch_concept
branch
from
86ee5c3 to
18e09f0
Compare
shrik3
reviewed
Apr 4, 2024
|
|
||
| #[derive(Debug)] | ||
| pub struct x86_64vCPU { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I don't have a better idea, that's the nature of this thingy. If linter is ok
then I'm ok :)
|
|
we really need this. (as soon as we merge with main). I mean not just the vcpu, but the
|
|
is this on the same agenda of #1136 , as well as the ongoing plan to abstract VM/VCPU creation? |
|
On Mon May 27, 2024 at 11:54 AM CEST, Tianhao Wang wrote:
is this on the same agenda of #1136
Were not planed in accordance, so maybe only per pure coincidence.
as well as the ongoing plan to abstract VM/VCPU creation?
A predecessor, I plan to use parts of it.
|
chl337
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The finished work should solve #1105 and allow smoother integration of other architectures in the future.
NOTE: #1109 causes the build to fail.