Skip to content

Commit

Permalink
Merge ElementsProject#1001: Adds an -fno-stack-check compile time fla…
Browse files Browse the repository at this point in the history
…g to OSX local builds

43657b5 Adds an -fno-stack-check compile time flag to OSX local builds (Mike Slominsk)

Pull request description:

  As a workaround for several elements issues on OSX 10.15 and later, this PR adds the `-fno-stack-check` flag to local (non-cross compile) OSX builds.

  Background: There seems to be a general issue with OSX (version >= 10.15) builds and clang's default use of `-fstack-check` which seems to be buggy enough to cause issues with multiple projects.

  closes ElementsProject#987 ElementsProject#998
  Also related to ElementsProject#782

Top commit has no ACKs.

Tree-SHA512: b8ecf10771da235878d10a59cddf22be9e587c2c6b278a62ea777d547b1a37abfbec4945842df2b581407e81dafcfc3df1d86e27f861a03322cb188917a5e940
  • Loading branch information
stevenroose committed Jun 2, 2021
2 parents 3172615 + 43657b5 commit eda3fbe
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,8 @@ case $host in
PKG_CONFIG_PATH="$qt5_prefix/lib/pkgconfig:$PKG_CONFIG_PATH"
export PKG_CONFIG_PATH
fi
dnl On some versions of osx stack check is turned on by default and is broken
AX_CHECK_COMPILE_FLAG([-fno-stack-check],[HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fno-stack-check"])
fi
else
case $build_os in
Expand Down

0 comments on commit eda3fbe

Please sign in to comment.