gyp: do not let v8dbg_ slip away on osx

Pass `-force_load` to linker when linking to `libv8_base` to preserve `v8dbg_` symbols, which are useful for debugging.
RIno256 · Jul 17, 2014 · 1d3d8c0 · 1d3d8c0
1 parent 9d9fc3f
commit 1d3d8c0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/common.gypi b/common.gypi
@@ -21,7 +21,7 @@
       ['OS != "win"', {
         'v8_postmortem_support': 'true'
       }],
-      ['GENERATOR == "ninja"', {
+      ['GENERATOR == "ninja" or OS== "mac"', {
         'OBJ_DIR': '<(PRODUCT_DIR)/obj',
         'V8_BASE': '<(PRODUCT_DIR)/libv8_base.a',
       }, {

diff --git a/node.gyp b/node.gyp
@@ -271,6 +271,14 @@
             'PLATFORM="darwin"',
           ],
         }],
+        [ 'OS=="mac" and v8_postmortem_support=="true"', {
+          # Do not let `v8dbg_` symbols slip away
+          'xcode_settings': {
+            'OTHER_LDFLAGS': [
+              '-Wl,-force_load,<(V8_BASE)',
+            ],
+          },
+        }],
         [ 'OS=="freebsd"', {
           'libraries': [
             '-lutil',