Fixes the circular reference in vm modules.

Fixes the circular reference problem. Closes nodejsGH-822.
RIno256 · Apr 12, 2011 · 81cbd42 · 81cbd42
1 parent 9b3b37e
commit 81cbd42
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/node_script.cc b/src/node_script.cc
@@ -221,6 +221,7 @@ Handle<Value> WrappedScript::CreateContext(const Arguments& args) {
     for (uint32_t i = 0; i < keys->Length(); i++) {
       Handle<String> key = keys->Get(Integer::New(i))->ToString();
       Handle<Value> value = sandbox->Get(key);
+      if(value == sandbox) { value = context; }
       context->Set(key, value);
     }
   }

diff --git a/test/simple/test-vm-create-context-circular-reference.js b/test/simple/test-vm-create-context-circular-reference.js
@@ -0,0 +1,12 @@
+var common = require('../common');
+var assert = require('assert');
+var vm = require('vm');
+
+var sbx = {};
+sbx.window = sbx;
+
+sbx = vm.createContext(sbx);
+
+sbx.test = 123;
+
+assert.equal(sbx.window.window.window.window.window.test, 123);