Skip to content

Commit

Permalink
test: add test for cluster.worker.destroy()
Browse files Browse the repository at this point in the history
Add a simple test to cover workers' implementation of
Worker.prototype.destroy(). Before adding this test, this code wouldn't
be covered by the tests suite, and any regression introduced in workers'
implementation of Worker.prototype.destroy wouldn't be caught.

Fixes: nodejs/node-v0.x-archive#8223
Reviewed-by: Trevor Norris <[email protected]>
  • Loading branch information
Julien Gilli authored and trevnorris committed Sep 18, 2014
1 parent cb4ed3c commit 9c992bd
Showing 1 changed file with 79 additions and 0 deletions.
79 changes: 79 additions & 0 deletions test/simple/test-cluster-worker-destroy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/*
* The goal of this test is to cover the Workers' implementation of
* Worker.prototype.destroy. Worker.prototype.destroy is called within
* the worker's context: once when the worker is still connected to the
* master, and another time when it's not connected to it, so that we cover
* both code paths.
*/

require('../common');
var cluster = require('cluster');
var assert = require('assert');

var worker1, worker2, workerExited, workerDisconnected;

if (cluster.isMaster) {
worker1 = cluster.fork();
worker2 = cluster.fork();

workerExited = 0;
workerDisconnected = 0;

[worker1, worker2].forEach(function(worker) {
worker.on('disconnect', ondisconnect);
worker.on('exit', onexit);
});

process.on('exit', onProcessExit);

} else {
if (cluster.worker.id === 1) {
// Call destroy when worker is disconnected
cluster.worker.process.on('disconnect', function() {
cluster.worker.destroy();
});

cluster.worker.disconnect();
} else {
// Call destroy when worker is not disconnected yet
cluster.worker.destroy();
}
}

function onProcessExit() {
assert.equal(workerExited,
2,
'When master exits, all workers should have exited too');
assert.equal(workerDisconnected,
2,
'When master exits, all workers should have disconnected');
}

function ondisconnect() {
++workerDisconnected;
}

function onexit() {
++workerExited;
}

0 comments on commit 9c992bd

Please sign in to comment.