Skip to content

Commit

Permalink
Remove expected failures for a couple of operators
Browse files Browse the repository at this point in the history 
Summary:
D51921135 added PT2 support for mutable operators. This added support for
the following operators:
- fbgemm::bounds_check_indices
- fbgemm::direct_mapped_lru_cache_populate_byte
- fbgemm::emb_inplace_update
- fbgemm::lru_cache_populate_byte
- fbgemm::lxu_cache_flush
- fbgemm::lxu_cache_locking_counter_decrement
- fbgemm::pruned_hashmap_insert
so we need to update the test failures (those
tests are no longer failing).

Reviewed By: bdhirsh

Differential Revision: D51942915

fbshipit-source-id: 867e791b7e86c0a72ea7d88837a56eb8b7f6cc48
  • Loading branch information
@zou3519 @facebook-github-bot
zou3519 authored and facebook-github-bot committed Dec 7, 2023
1 parent a75b43f commit 4390af5
Showing 1 changed file with 7 additions and 218 deletions.
225 changes: 7 additions & 218 deletions fbgemm_gpu/test/failures_dict_fast.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,120 +88,7 @@
"status": "xfail"
}
},
"fbgemm::bounds_check_indices": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp16_pmMEAN": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp16_pmNONE": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp16_pmSUM": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp32_pmMEAN": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp32_pmNONE": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp32_pmSUM": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_none": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_none_with_rowwise_adagrad": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_optimizers_adagrad": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_optimizers_adam": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_optimizers_lamb": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_optimizers_lars": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_sgd": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_sgd_really_long_segments": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_bounds_check": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_miss_counter": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_pipeline": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_prefetch_pipeline": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_prefetch_pipeline_stream_1": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_prefetch_pipeline_stream_2": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_forward_fused_pooled_emb_quant": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_int_nbit_split_embedding_uvm_caching_codegen_lookup_function": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_cache_miss_counter": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_direct_mapped_uvm_cache_stats": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_forward_fused_pooled_emb_quant": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_forward_uvm_cache": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_uvm_cache_stats": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_stb_uvm_cache_stats": {
"comment": "",
"status": "xfail"
}
},
"fbgemm::bounds_check_indices": {},
"fbgemm::dense_embedding_codegen_lookup_function": {
"SplitTableBatchedEmbeddingsTest.test_autograd_registration__test_backward_dense": {
"comment": "",
Expand All @@ -212,16 +99,7 @@
"status": "xfail"
}
},
"fbgemm::direct_mapped_lru_cache_populate_byte": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_direct_mapped_uvm_cache_stats": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_forward_uvm_cache": {
"comment": "",
"status": "xfail"
}
},
"fbgemm::direct_mapped_lru_cache_populate_byte": {},
"fbgemm::direct_mapped_lxu_cache_lookup": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_direct_mapped_uvm_cache_stats": {
"comment": "",
Expand All @@ -232,12 +110,7 @@
"status": "xfail"
}
},
"fbgemm::emb_inplace_update": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_embedding_inplace_update": {
"comment": "",
"status": "xfail"
}
},
"fbgemm::emb_inplace_update": {},
"fbgemm::get_unique_indices": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_unique_lxu_cache_lookup": {
"comment": "",
Expand Down Expand Up @@ -470,80 +343,9 @@
"status": "skip"
}
},
"fbgemm::lru_cache_populate_byte": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_int_nbit_split_embedding_uvm_caching_codegen_lookup_function": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_cache_miss_counter": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_forward_uvm_cache": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_uvm_cache_stats": {
"comment": "",
"status": "xfail"
}
},
"fbgemm::lxu_cache_flush": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp16_pmMEAN": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp16_pmNONE": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp16_pmSUM": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp32_pmMEAN": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp32_pmNONE": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp32_pmSUM": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_sgd": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_sgd_really_long_segments": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_pipeline": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_prefetch_pipeline": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_prefetch_pipeline_stream_1": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_cache_prefetch_pipeline_stream_2": {
"comment": "",
"status": "xfail"
}
},
"fbgemm::lxu_cache_locking_counter_decrement": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_lxu_cache_locking_counter_decrement": {
"comment": "",
"status": "xfail"
}
},
"fbgemm::lru_cache_populate_byte": {},
"fbgemm::lxu_cache_flush": {},
"fbgemm::lxu_cache_locking_counter_decrement": {},
"fbgemm::lxu_cache_lookup": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_backward_adagrad_fp16_pmMEAN": {
"comment": "",
Expand Down Expand Up @@ -671,20 +473,7 @@
"status": "xfail"
}
},
"fbgemm::pruned_hashmap_insert": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_forward_gpu_no_cache": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_forward_uvm_cache": {
"comment": "",
"status": "xfail"
},
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_pruning": {
"comment": "",
"status": "xfail"
}
},
"fbgemm::pruned_hashmap_insert": {},
"fbgemm::pruned_hashmap_lookup": {
"SplitTableBatchedEmbeddingsTest.test_faketensor__test_nbit_forward_uvm_cache": {
"comment": "",
Expand Down

0 comments on commit 4390af5

Please sign in to comment.