Skip to content

Commit

Permalink
remove accelerator_view::get_hsa_queue()
Browse files Browse the repository at this point in the history
This function returns the underlying hsa_queue_t for an
accelerator_view, but this mapping is not stable in the presence of
queue stealing. It was introduced for HIP, but it is not used
anywhere, and it is unsafe anyway.
  • Loading branch information
ssahasra authored and scchan committed May 2, 2019
1 parent b1b1677 commit aabad26
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 54 deletions.
10 changes: 0 additions & 10 deletions include/hc.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -492,16 +492,6 @@ class accelerator_view {
return pQueue->isEmpty();
}

/**
* Returns an opaque handle which points to the underlying HSA queue.
*
* @return An opaque handle of the underlying HSA queue, if the accelerator
* view is based on HSA. NULL if otherwise.
*/
void* get_hsa_queue() {
return pQueue->getHSAQueue();
}

/**
* Returns an opaque handle which points to the underlying HSA agent.
*
Expand Down
3 changes: 0 additions & 3 deletions include/kalmar_runtime.h
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,6 @@ class KalmarQueue
/// Is the queue empty? Same as getPendingAsyncOps but may be faster.
virtual bool isEmpty() { return 0; }

/// get underlying native queue handle
virtual void* getHSAQueue() { return nullptr; }

/// get underlying native agent handle
virtual void* getHSAAgent() { return nullptr; }

Expand Down
4 changes: 0 additions & 4 deletions lib/hsa/mcwamp_hsa.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1972,10 +1972,6 @@ class HSAQueue final : public KalmarQueue
}
}

void* getHSAQueue() override {
return static_cast<void*>(rocrQueue->_hwQueue);
}

hsa_queue_t *acquireLockedRocrQueue();

void releaseLockedRocrQueue();
Expand Down
37 changes: 0 additions & 37 deletions tests/Unit/HC/test1.cpp

This file was deleted.

0 comments on commit aabad26

Please sign in to comment.