Enable CMake HIP language #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX.
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
stanleytsang-amd
approved these changes
Dec 3, 2024
umfranzw
merged commit 7bbde6a
into
ROCm:release-staging/rocm-rel-6.4
19 of 20 checks passed
stanleytsang-amd
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Include device_copy header (#433) The device/device_copy.hpp header was missing from the main hipcub.hpp header file. This change just adds it back. * [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435) * removed ussage of std::unary/binary_function * updated changelog * Enable CMake HIP language (#434) If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX. Co-authored-by: Lauren Wrubleski <[email protected]> * Add hipcub::AliasTemporaries and some macros (#438) * Resolve "Add missing macros in HIPCUB API" * Resolve "Add AliasTemporaries function" * Added macro names to CHANGELOG --------- Co-authored-by: Wayne Franz <[email protected]> Co-authored-by: Lauren Wrubleski <[email protected]> Co-authored-by: Nick Breed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the HIP language can be used, the HIP_USECXX variable sets hipCUB to use the CMake HIP language rather than CXX.