forked from llvm-mirror/llvm
-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[llvm-objcopy] - Emit error and don't crash if program header reaches…
… past end of file. This is https://bugs.llvm.org/show_bug.cgi?id=42122. If an object file has a size less than program header's file [offset + size] (i.e. if we have overflow), llvm-objcopy crashes instead of reporting a error. The patch fixes this issue. Differential revision: https://reviews.llvm.org/D62898 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@362778 91177308-0d34-0410-b5e6-96231b3b80d8
- Loading branch information
George Rimar
committed
Jun 7, 2019
1 parent
d2e9d07
commit 10b2fe5
Showing
2 changed files
with
50 additions
and
0 deletions.
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
test/tools/llvm-objcopy/ELF/invalid-p_filesz-p_offset.test
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
## In this case, we have a program header with a file size that | ||
## overflows the binary size. Check llvm-objcopy doesn't crash | ||
## and report this error properly. | ||
|
||
# RUN: yaml2obj --docnum=1 %s -o %t1.o | ||
# RUN: not llvm-objcopy %t1.o 2>&1 | FileCheck %s --check-prefix=ERR1 | ||
# ERR1: error: program header with offset 0x1b8 and file size 0x100000 goes past the end of the file | ||
|
||
--- !ELF | ||
FileHeader: | ||
Class: ELFCLASS64 | ||
Data: ELFDATA2LSB | ||
Type: ET_EXEC | ||
Machine: EM_X86_64 | ||
Sections: | ||
- Name: .foo | ||
Type: SHT_PROGBITS | ||
ProgramHeaders: | ||
- Type: PT_LOAD | ||
FileSize: 0x100000 | ||
Sections: | ||
- Section: .foo | ||
|
||
## A similar case, but now the p_offset property of the program header is too large. | ||
|
||
# RUN: yaml2obj --docnum=2 %s -o %t2.o | ||
# RUN: not llvm-objcopy %t2.o 2>&1 | FileCheck %s --check-prefix=ERR2 | ||
# ERR2: error: program header with offset 0x100000 and file size 0x1 goes past the end of the file | ||
|
||
--- !ELF | ||
FileHeader: | ||
Class: ELFCLASS64 | ||
Data: ELFDATA2LSB | ||
Type: ET_EXEC | ||
Machine: EM_X86_64 | ||
Sections: | ||
- Name: .foo | ||
Type: SHT_PROGBITS | ||
Size: 1 | ||
ProgramHeaders: | ||
- Type: PT_LOAD | ||
Offset: 0x100000 | ||
FileSize: 1 | ||
Sections: | ||
- Section: .foo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters