Merge pull request webpack#11105 from webpack/mf/semver

add full Semantic Versioning for Shared Modules
RReverser · Jul 6, 2020 · e27eb83 · e27eb83
2 parents e8ed3d8 + 767ac32
commit e27eb83
Show file tree

Hide file tree

Showing 37 changed files with 1,724 additions and 879 deletions.
diff --git a/cspell.json b/cspell.json
@@ -174,6 +174,7 @@
     "darkblue",
     "darkgreen",
     "darkred",
+    "eqeqeq",
 
     "webassemblyjs",
     "fsevents",

diff --git a/declarations/_sharing.d.ts b/declarations/_sharing.d.ts
@@ -12,10 +12,6 @@ export type Shared = (SharedItem | SharedObject)[] | SharedObject;
  * A module that should be shared in the share scope.
  */
 export type SharedItem = string;
-/**
- * Version number as array. Numbers and strings are accepted. Strings are treated as tags, which only match exactly. Numbers can match higher numbers.
- */
-export type SharedVersionArray = (number | string)[];
 
 export interface _Sharing {
 	[k: string]: any;
@@ -48,7 +44,7 @@ export interface SharedConfig {
 	/**
 	 * Version requirement from module in share scope.
 	 */
-	requiredVersion?: false | string | SharedVersionArray;
+	requiredVersion?: false | string;
 	/**
 	 * Module is looked up under this key from the share scope.
 	 */
@@ -68,5 +64,5 @@ export interface SharedConfig {
 	/**
 	 * Version of the provided module. Will replace lower matching versions, but not higher.
 	 */
-	version?: false | string | SharedVersionArray;
+	version?: false | string;
 }
diff --git a/declarations/plugins/container/ModuleFederationPlugin.d.ts b/declarations/plugins/container/ModuleFederationPlugin.d.ts
@@ -95,10 +95,6 @@ export type Shared = (SharedItem | SharedObject)[] | SharedObject;
  * A module that should be shared in the share scope.
  */
 export type SharedItem = string;
-/**
- * Version number as array. Numbers and strings are accepted. Strings are treated as tags, which only match exactly. Numbers can match higher numbers.
- */
-export type SharedVersionArray = (number | string)[];
 
 export interface ModuleFederationPluginOptions {
 	/**
@@ -265,7 +261,7 @@ export interface SharedConfig {
 	/**
 	 * Version requirement from module in share scope.
 	 */
-	requiredVersion?: false | string | SharedVersionArray;
+	requiredVersion?: false | string;
 	/**
 	 * Module is looked up under this key from the share scope.
 	 */
@@ -285,5 +281,5 @@ export interface SharedConfig {
 	/**
 	 * Version of the provided module. Will replace lower matching versions, but not higher.
 	 */
-	version?: false | string | SharedVersionArray;
+	version?: false | string;
 }
diff --git a/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts b/declarations/plugins/sharing/ConsumeSharedPlugin.d.ts
@@ -12,10 +12,6 @@ export type Consumes = (ConsumesItem | ConsumesObject)[] | ConsumesObject;
  * A module that should be consumed from share scope.
  */
 export type ConsumesItem = string;
-/**
- * Version number as array. Numbers and strings are accepted. Strings are treated as tags, which only match exactly. Numbers can match higher numbers.
- */
-export type SharedVersionArray = (number | string)[];
 
 /**
  * Options for consuming shared modules.
@@ -58,7 +54,7 @@ export interface ConsumesConfig {
 	/**
 	 * Version requirement from module in share scope.
 	 */
-	requiredVersion?: false | string | SharedVersionArray;
+	requiredVersion?: false | string;
 	/**
 	 * Module is looked up under this key from the share scope.
 	 */

diff --git a/declarations/plugins/sharing/ProvideSharedPlugin.d.ts b/declarations/plugins/sharing/ProvideSharedPlugin.d.ts
@@ -12,10 +12,6 @@ export type Provides = (ProvidesItem | ProvidesObject)[] | ProvidesObject;
  * Request to a module that should be provided as shared module to the share scope (will be resolved when relative).
  */
 export type ProvidesItem = string;
-/**
- * Version number as array. Numbers and strings are accepted. Strings are treated as tags, which only match exactly. Numbers can match higher numbers.
- */
-export type SharedVersionArray = (number | string)[];
 
 export interface ProvideSharedPluginOptions {
 	/**
@@ -55,5 +51,5 @@ export interface ProvidesConfig {
 	/**
 	 * Version of the provided module. Will replace lower matching versions, but not higher.
 	 */
-	version?: false | string | SharedVersionArray;
+	version?: false | string;
 }
diff --git a/declarations/plugins/sharing/SharePlugin.d.ts b/declarations/plugins/sharing/SharePlugin.d.ts
@@ -12,10 +12,6 @@ export type Shared = (SharedItem | SharedObject)[] | SharedObject;
  * A module that should be shared in the share scope.
  */
 export type SharedItem = string;
-/**
- * Version number as array. Numbers and strings are accepted. Strings are treated as tags, which only match exactly. Numbers can match higher numbers.
- */
-export type SharedVersionArray = (number | string)[];
 
 /**
  * Options for shared modules.
@@ -58,7 +54,7 @@ export interface SharedConfig {
 	/**
 	 * Version requirement from module in share scope.
 	 */
-	requiredVersion?: false | string | SharedVersionArray;
+	requiredVersion?: false | string;
 	/**
 	 * Module is looked up under this key from the share scope.
 	 */
@@ -78,5 +74,5 @@ export interface SharedConfig {
 	/**
 	 * Version of the provided module. Will replace lower matching versions, but not higher.
 	 */
-	version?: false | string | SharedVersionArray;
+	version?: false | string;
 }