Fix concurrency issues in tests to make build stable. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrypacker
commented
Feb 13, 2025
| @@ -175,8 +176,10 @@ public boolean isLogDisabled() { | |||
| return logDisabled; | |||
| } | |||
|
|
|||
| public LogBuffer<LogMultipleRecord> getBuffer() { | |||
| return buffer; | |||
| public void withBuffer(Consumer<LogBuffer<LogMultipleRecord>> bufferConsumer) { | |||
There was a problem hiding this comment.
This is one of the 2 changes that make the tests pass, accessing the buffer in a thread safe manner.
terrypacker
commented
Feb 13, 2025
| @@ -204,8 +205,10 @@ public boolean isLogDisabled() { | |||
| return logDisabled; | |||
| } | |||
|
|
|||
| public LogBuffer<LogRecord> getBuffer() { | |||
| return buffer; | |||
| public void withBuffer(Consumer<LogBuffer<LogRecord>> bufferConsumer) { | |||
There was a problem hiding this comment.
This is one of the 2 changes that make the tests pass, accessing the buffer in a thread safe manner.
As per MANGO-1975
As per MANGO-1975
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found problems with 2 randomly failing test classes:
The problem was due to accessing a non thread safe collection of the trend logs in the tests. The solution fixes the tests by wrapping access in a synchronization block and exposing a utility method to check size of list in a thread safe way.
I suspect there are more problems but I've run the tests thousands of times and seem to have rooted out most of the problems with these 2 classes. I suspect there may still be problems with:
com.serotonin.bacnet4j.obj.logBuffer.LogBufferclass. (Need to look at other tests)com.serotonin.bacnet4j.obj.EventNotifListeneras this collection is also not thread safe.Note
Before closing this out we should create some work that will review the internal use of the LogBuffer class as it is definitely not thread safe and can potentially be accessed in a non-thread-safe way via its interface.