Merge pull request GoogleCloudPlatform#30 from kyasbal/pr-ga

Enable Github Action on Pull requests

.github/workflows/pr-request.yaml

@@ -0,0 +1,167 @@
+# Copyright 2024 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PR Tests
+
+on:
+  pull_request:
+    branches:
+      - 'main'
+
+jobs:
+  backend-tests:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: 'read'
+      id-token: 'write'
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version-file: './go.mod'
+
+    # TODO: Configure Github Action after getting the Workload Identity Pool for this project
+    # https://github.com/GoogleCloudPlatform/khi/issues/29
+    # - name: Authenticate to Google Cloud
+    #   uses: google-github-actions/auth@v2
+    #   with:
+    #     workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY_PROVIDER }}
+    #     project_id: ${{ secrets.GCP_PROJECT_ID }}
+
+    # - name: Install gcloud CLI and get token
+    #   uses: google-github-actions/setup-gcloud@v2
+
+    # - name: Get gcloud token
+    #   id: gcloud-token
+    #   run: |
+    #     echo "#!/bin/bash\necho \"$(gcloud auth print-access-token)\"" > /usr/bin/gcloud
+    #     chmod +x /usr/bin/gcloud
+
+    # - name: Backend Test
+    #   run: |
+    #     mkdir dist
+    #     # A placeholder frontend code read from backend test
+    #     echo "" > ./dist/index.html
+    #     make coverage-go
+
+    - name: Backend Format and Lint Check
+      run: |
+        make check-format-go
+        make lint-go
+
+  frontend-tests:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: 'read'
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version-file: './.node-version'
+
+    - name: Set up Go # Go dependency is needed for `make prepare-frontend`
+      uses: actions/setup-go@v5
+      with:
+        go-version-file: './go.mod'
+
+    - name: Install jq
+      run: sudo apt-get update && sudo apt-get install -y jq
+
+    - name: npm install
+      working-directory: ./web
+      run: npm ci
+
+    - name: Generate frontend codes
+      run: make prepare-frontend
+
+    - name: Install Chrome for Angular Test
+      uses: browser-actions/setup-chrome@v1
+      with:
+        chrome-version: stable
+
+    - name: Angular Test
+      run: make coverage-web
+
+    - name: Frontend Format and Lint Check
+      run: |
+        make check-format-web
+        make lint-web
+
+  build-frontend:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: 'read'
+    strategy:
+      matrix:
+        configuration: [prod, dev]
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version-file: './.node-version'
+
+    - name: Set up Go # Go dependency is needed for `make prepare-frontend`
+      uses: actions/setup-go@v5
+      with:
+        go-version-file: './go.mod'
+
+    - name: npm install
+      working-directory: ./web
+      run: npm ci
+
+    - name: Generate frontend codes
+      run: make prepare-frontend
+
+    - name: Build web
+      working-directory: ./web
+      run: npx ng build --configuration ${{ matrix.configuration }}
+
+  license-header-check:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: './go.mod'
+
+      - name: Install addlicense package
+        run: go install github.com/google/addlicense@latest
+
+      - name: Run addlicense
+        id: license_header_check
+        run: addlicense  -c "Google LLC" -l apache -v -check .
+
+      - name: run if license_header_check failed
+        if: failure() && steps.license_header_check.outcome == 'failure'
+        env:
+          PULL_REQUEST: ${{ github.event.number }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          echo "License header check failed.\nConsider running \`make add-license-headers\`.\n(Please check ./scripts/make/codegen.mk for more details.)" > /tmp/comment_body
+          gh pr comment "${PULL_REQUEST}" -F /tmp/comment_body

web/src/environments/environment.dev.ts

@@ -19,7 +19,8 @@ import { PublicKHIExtension } from 'src/app/extensions/public/module';
 export const environment = {
   production: false,
   viewerMode: false,
-  bugReportUrl: 'https://github.com/GoogleCloudPlatform/khi/issues/new?template=Blank+issue',
+  bugReportUrl:
+    'https://github.com/GoogleCloudPlatform/khi/issues/new?template=Blank+issue',
   documentUrl: 'https://github.com/GoogleCloudPlatform/khi',
   pluginModules: [PublicKHIExtension],
   options: {} as Record<string, unknown>,

web/src/environments/environment.prod.ts

@@ -19,7 +19,8 @@ import { PublicKHIExtension } from 'src/app/extensions/public/module';
 export const environment = {
   production: true,
   viewerMode: false,
-  bugReportUrl: 'https://github.com/GoogleCloudPlatform/khi/issues/new?template=Blank+issue',
+  bugReportUrl:
+    'https://github.com/GoogleCloudPlatform/khi/issues/new?template=Blank+issue',
   documentUrl: 'https://github.com/GoogleCloudPlatform/khi',
   pluginModules: [PublicKHIExtension],
   options: {} as Record<string, unknown>,