Skip to content

Commit

Permalink
Mark the functions which are overriden in KeyManagerBase with override.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 214402785
GitOrigin-RevId: ed35b3cb52e99d7e41cbe104f647cc38c5429d23
  • Loading branch information
tholenst authored and Tink Team committed Sep 25, 2018
1 parent e94b8d0 commit 17dd243
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cc/core/key_manager_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class KeyFactoryBase : public KeyFactory {
KeyFactoryBase() {}

crypto::tink::util::StatusOr<std::unique_ptr<portable_proto::MessageLite>>
NewKey(const portable_proto::MessageLite& key_format) const {
NewKey(const portable_proto::MessageLite& key_format) const override {
if (key_format.GetTypeName() != KeyFormatProto().GetTypeName()) {
return crypto::tink::util::Status(
util::error::INVALID_ARGUMENT,
Expand All @@ -52,7 +52,7 @@ class KeyFactoryBase : public KeyFactory {
}

crypto::tink::util::StatusOr<std::unique_ptr<portable_proto::MessageLite>>
NewKey(absl::string_view serialized_key_format) const {
NewKey(absl::string_view serialized_key_format) const override {
KeyFormatProto key_format;
if (!key_format.ParseFromString(std::string(serialized_key_format))) {
return crypto::tink::util::Status(
Expand All @@ -64,7 +64,7 @@ class KeyFactoryBase : public KeyFactory {
}

crypto::tink::util::StatusOr<std::unique_ptr<google::crypto::tink::KeyData>>
NewKeyData(absl::string_view serialized_key_format) const {
NewKeyData(absl::string_view serialized_key_format) const override {
auto new_key_result = NewKey(serialized_key_format);
if (!new_key_result.ok()) return new_key_result.status();
auto new_key =
Expand Down

0 comments on commit 17dd243

Please sign in to comment.