Fix for gnikyt#426 - Look up plan thats not default

RandomWeasel · Mar 25, 2020 · 115949e · 115949e
1 parent 362e9a2
commit 115949e
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/ShopifyApp/Actions/GetPlanUrl.php b/src/ShopifyApp/Actions/GetPlanUrl.php
@@ -65,10 +65,8 @@ public function __invoke(ShopId $shopId, NullablePlanId $planId): string
         // Get the shop
         $shop = $this->shopQuery->getById($shopId);
 
-        // If the plan is null, get a plan
-        if ($planId->isNull()) {
-            $plan = $this->planQuery->getDefault();
-        }
+        // Get the plan
+        $plan = $planId->isNull() ? $this->planQuery->getDefault() : $this->planQuery->getById($planId);
 
         $api = $shop->apiHelper()->createCharge(
             ChargeType::fromNative($plan->getType()->toNative()),